General refactoring #11
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix bux for starting position = 0 Update state to stopped even if it didn't move Enable layer caching Fix state topic
santam85
commented
Jan 25, 2023
| platforms: linux/amd64,linux/arm64,linux/arm/v7 | ||
| push: true | ||
| tags: | | ||
| santam/wms-mqtt:latest |
There was a problem hiding this comment.
This will need changing, can be parameterized with repo secrets or workflow parameters
Fix dockerfile paths in workflow Refactor to avoid nested config files and paths in pipeline Replaced logger with winston Retain config messages to be robust against HA restarts Only set open/closed when stopped
santam85
force-pushed
the
main
branch
3 times, most recently
from
40f583c to
14876c7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey @giannello,
not an ideal PR as it's massive and contains a lot of unrelated changes, but it was useful for me to refactor the code to debug and improve the implementation with more ease. Feel free to pick what you like, and add comments in case you have questions.
warema-wms-venetian-blindsto allow upgrading dependencies of serialport and parsers