resources: add scripts to make and extract arm kernel #60

Harshil2107 · 2024-10-29T22:19:18Z

No description provided.

Harshil2107 · 2024-10-29T22:23:34Z

I am adding gem5-bridge driver based on #48

src/ubuntu-generic-diskimages/scripts/post-installation.sh

powerjg · 2024-10-30T00:24:46Z

src/ubuntu-generic-diskimages/scripts/post-installation.sh

@@ -47,21 +61,29 @@ if [ -z "$ISA" ]; then
 fi

 # Just get the files we need
-git clone https://github.com/gem5/gem5.git --depth=1 --filter=blob:none --no-checkout --sparse --single-branch --branch=stable
+git clone https://github.com/nkrim/gem5.git --depth=1 --filter=blob:none --no-checkout --sparse --single-branch --branch=gem5-bridge


I assume this is just a placeholder, but don't forget to fix this.

erin-le

I tested this by building the disk image, then using the disk image and kernel as resources in a script that Harshil provided. It boots, so this LGTM

src/ubuntu-generic-diskimages/http/arm-24-04/user-data

Harshil2107 · 2024-11-22T23:51:15Z

I think going for the method that I used in the 22.04 image, is better than the one that is used in 24.04 image. The only issue is that you have to give write permissions to the the directory we are mounting to the docker to get the kernel and the modules.

does this look good, If so I can update the 24.04 image as well

src/ubuntu-generic-diskimages/make-kernel-and-gem5-bridge-driver.md

powerjg · 2024-11-22T23:46:14Z

src/ubuntu-generic-diskimages/make-kernel-and-gem5-bridge-driver.md

+in the `/workspace/source`, lets get the driver files
+
+```bash
+git clone https://github.com/nkrim/gem5.git --depth=1 --filter=blob:none --no-checkout --sparse --single-branch --branch=gem5-bridge


get this committed to gem5 and use the gem5 source.

src/ubuntu-generic-diskimages/make-kernel-and-gem5-bridge-driver.md

src/ubuntu-generic-diskimages/22.04-dockerfile/Dockerfile

…erfiles

Harshil2107 · 2024-11-26T19:33:29Z

I built and tests the gem5 bridge driver with both the 22.04 and 24.04 disk images. I built the base image and then built the npb image using this base image. I was able to run the benchmark without sudo in gem5.

The only blocker to his now should be getting the m5 driver code in gem5.

erin-le

Looks good overall. There are just a few typos and minor things that could be added in make-kernel-and-gem5-bridge-driver.md.

src/ubuntu-generic-diskimages/make-kernel-and-gem5-bridge-driver.md

powerjg · 2024-12-04T19:29:26Z

src/ubuntu-generic-diskimages/24.04-dockerfile/Dockerfile

+    rm -rf build
+
+# Use bash as the default shell
+CMD ["/bin/bash"]


Should be removed so the image won't be used interactively.

powerjg · 2024-12-04T19:29:49Z

src/ubuntu-generic-diskimages/24.04-dockerfile/Dockerfile

+    make -j 32 && \
+    make INSTALL_MOD_PATH=/workspace/output modules_install
+
+RUN git clone https://github.com/nkrim/gem5.git --depth=1 --filter=blob:none --no-checkout --sparse --single-branch --branch=gem5-bridge && \


Must be changed before merging

erin-le · 2024-12-04T20:06:25Z

src/ubuntu-generic-diskimages/make-kernel-and-gem5-bridge-driver.md

@@ -64,7 +64,8 @@ This document outlines the steps to build a Linux kernel and its modules with th

 ### Add Kernel Modules to the Disk Image

- Add a Packer file provisioner to copy the modules to the disk image:
+- Add a Packer file provisioner to copy the modules to the disk image.


Suggested change

- Add a Packer file provisioner to copy the modules to the disk image.

- Add a Packer file provisioner to copy the modules to the disk image. The Packer script is located at `ubuntu-generic-diskimages/packer-scripts/arm-ubuntu.pkr.hcl`.

erin-le · 2024-12-04T20:08:09Z

src/ubuntu-generic-diskimages/make-kernel-and-gem5-bridge-driver.md

@@ -64,7 +64,8 @@ This document outlines the steps to build a Linux kernel and its modules with th

 ### Add Kernel Modules to the Disk Image

- Add a Packer file provisioner to copy the modules to the disk image:
+- Add a Packer file provisioner to copy the modules to the disk image.
+Make sure that this provisioner is added before the shell provisioner as we will used these files in the `post-installation.sh`:


Suggested change

Make sure that this provisioner is added before the shell provisioner as we will used these files in the `post-installation.sh`:

Make sure that this provisioner is added before the shell provisioner, as these files are used when the shell provisioner runs`post-installation.sh`:

erin-le · 2024-12-04T20:18:03Z

src/ubuntu-generic-diskimages/make-kernel-and-gem5-bridge-driver.md

@@ -148,16 +149,18 @@ This document outlines the steps to build a Linux kernel and its modules with th

 ### Add Kernel Modules to the Disk Image

- Add a Packer file provisioner to copy the modules to the disk image:
+- Add a Packer file provisioner to copy the modules to the disk image.


Suggested change

- Add a Packer file provisioner to copy the modules to the disk image.

- Add a Packer file provisioner to copy the modules to the disk image. The Packer script is located at `ubuntu-generic-diskimages/packer-scripts/arm-ubuntu.pkr.hcl`.

erin-le · 2024-12-04T20:18:24Z

src/ubuntu-generic-diskimages/make-kernel-and-gem5-bridge-driver.md

@@ -176,3 +179,16 @@ This document outlines the steps to build a Linux kernel and its modules with th
 ### Test with gem5

 - Use the disk image and the kernel to run a gem5 filesystem simulation, ensuring the new kernel and modules are correctly set up.
+
+- You can use the following code snipped to use the disk image and kernel you made.


Suggested change

- You can use the following code snipped to use the disk image and kernel you made.

- You can use the following code snippet to use the disk image and kernel you made.

erin-le · 2024-12-04T21:06:06Z

src/ubuntu-generic-diskimages/make-kernel-and-gem5-bridge-driver.md

@@ -73,7 +74,8 @@ This document outlines the steps to build a Linux kernel and its modules with th
  }
  ```

- Update the post-install script to move the modules into the correct location and regenerate the initramfs:
+- Update the post-install script to move the modules into the correct location and regenerate the initramfs.


Suggested change

- Update the post-install script to move the modules into the correct location and regenerate the initramfs.

- Add the following code snippet to the post-install script to move the modules into the correct location and regenerate the initramfs. The post-install script is located at `ubuntu-generic-diskimages/scripts/post-installation.sh`.

erin-le · 2024-12-04T21:08:16Z

src/ubuntu-generic-diskimages/make-kernel-and-gem5-bridge-driver.md

@@ -73,7 +74,8 @@ This document outlines the steps to build a Linux kernel and its modules with th
  }
  ```

- Update the post-install script to move the modules into the correct location and regenerate the initramfs:
+- Update the post-install script to move the modules into the correct location and regenerate the initramfs.
+Make sure the modules are moved before using `gem5-bridge` or compiling benchmarks with `gem5-bridge`:


Suggested change

Make sure the modules are moved before using `gem5-bridge` or compiling benchmarks with `gem5-bridge`:

Make sure the modules are moved before using `gem5-bridge` or compiling benchmarks with `gem5-bridge`, i.e. add the snippet before the line `echo "Building and installing gem5-bridge (m5) and libm5"`:

erin-le · 2024-12-04T21:09:37Z

src/ubuntu-generic-diskimages/make-kernel-and-gem5-bridge-driver.md

  }
  ```

- Update the post-install script to move the modules into the correct location and regenerate the initramfs:
+- Update the post-install script to move the modules into the correct location and regenerate the initramfs.


Suggested change

- Update the post-install script to move the modules into the correct location and regenerate the initramfs.

- Add the following code snippet to the post-install script to move the modules into the correct location and regenerate the initramfs. The post-install script is located at `ubuntu-generic-diskimages/scripts/post-installation.sh`.

erin-le · 2024-12-04T21:10:03Z

src/ubuntu-generic-diskimages/make-kernel-and-gem5-bridge-driver.md

  }
  ```

- Update the post-install script to move the modules into the correct location and regenerate the initramfs:
+- Update the post-install script to move the modules into the correct location and regenerate the initramfs.
+Make sure the modules are moved before using `gem5-bridge` or compiling benchmarks with `gem5-bridge`:


Suggested change

Make sure the modules are moved before using `gem5-bridge` or compiling benchmarks with `gem5-bridge`:

Make sure the modules are moved before using `gem5-bridge` or compiling benchmarks with `gem5-bridge`, i.e. add the snippet before the line `echo "Building and installing gem5-bridge (m5) and libm5"`:

erin-le · 2024-12-04T21:10:56Z

src/ubuntu-generic-diskimages/make-kernel-and-gem5-bridge-driver.md

@@ -176,3 +179,16 @@ This document outlines the steps to build a Linux kernel and its modules with th
 ### Test with gem5

 - Use the disk image and the kernel to run a gem5 filesystem simulation, ensuring the new kernel and modules are correctly set up.


Suggested change

- Use the disk image and the kernel to run a gem5 filesystem simulation, ensuring the new kernel and modules are correctly set up.

- Use the disk image and the kernel to run a gem5 filesystem simulation, ensuring the new kernel and modules are correctly set up. See the bottom of this file for an example.

resources: add scripts to make and extract arm kernel

970f97c

powerjg reviewed Oct 30, 2024

View reviewed changes

Harshil2107 added 2 commits November 4, 2024 15:56

resources: update scripts to build the kernel

c85807e

resources: update disk size to 50gb

22d3fe2

erin-le self-requested a review November 13, 2024 18:00

erin-le previously approved these changes Nov 18, 2024

View reviewed changes

resources: Update building kernel and modules on host

d8d4d3c

Harshil2107 dismissed erin-le’s stale review via d8d4d3c November 20, 2024 23:21

Harshil2107 added 2 commits November 20, 2024 15:42

resources: clean up post install script

d9573fb

resources: add docker files to make kernel for ubuntu 22.04 image

c4ace1d

powerjg reviewed Nov 22, 2024

View reviewed changes

src/ubuntu-generic-diskimages/http/arm-24-04/user-data Outdated Show resolved Hide resolved

powerjg reviewed Nov 22, 2024

View reviewed changes

Harshil2107 added 5 commits November 25, 2024 14:32

resources: Update docker files to make and kerenl and modules on build

b497d6f

resources: Update and clean up documentation to refer to the new dock…

9678f1a

…erfiles

resources: Update documentation

6f6a870

resources: add link to new documentation to BUILDING.md

67d061b

resoruces: update dockerfile to remove chmod

606cb28

Harshil2107 requested a review from erin-le November 26, 2024 19:16

resources: revert size changes

327a0b4

Harshil2107 requested a review from powerjg November 26, 2024 19:30

Harshil2107 mentioned this pull request Nov 26, 2024

gem5 Bridge Driver gem5/gem5#1480

Open

Harshil2107 added 2 commits December 2, 2024 15:46

resources: Update size of images

78e7a39

resources: clean up comments

0f63a99

erin-le reviewed Dec 4, 2024

View reviewed changes

resources: update documentation

4624ee3

Harshil2107 requested a review from erin-le December 4, 2024 17:46

powerjg requested changes Dec 4, 2024

View reviewed changes

erin-le reviewed Dec 4, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

resources: add scripts to make and extract arm kernel #60

resources: add scripts to make and extract arm kernel #60

Harshil2107 commented Oct 29, 2024

Harshil2107 commented Oct 29, 2024

powerjg Oct 30, 2024

erin-le left a comment

Harshil2107 commented Nov 22, 2024

powerjg Nov 22, 2024

Harshil2107 commented Nov 26, 2024

erin-le left a comment

powerjg Dec 4, 2024

powerjg Dec 4, 2024

erin-le Dec 4, 2024

erin-le Dec 4, 2024

erin-le Dec 4, 2024

erin-le Dec 4, 2024

erin-le Dec 4, 2024

erin-le Dec 4, 2024

erin-le Dec 4, 2024

erin-le Dec 4, 2024

erin-le Dec 4, 2024

	- Add a Packer file provisioner to copy the modules to the disk image.
	- Add a Packer file provisioner to copy the modules to the disk image. The Packer script is located at `ubuntu-generic-diskimages/packer-scripts/arm-ubuntu.pkr.hcl`.

	Make sure that this provisioner is added before the shell provisioner as we will used these files in the `post-installation.sh`:
	Make sure that this provisioner is added before the shell provisioner, as these files are used when the shell provisioner runs`post-installation.sh`:

	- You can use the following code snipped to use the disk image and kernel you made.
	- You can use the following code snippet to use the disk image and kernel you made.

	- Update the post-install script to move the modules into the correct location and regenerate the initramfs.
	- Add the following code snippet to the post-install script to move the modules into the correct location and regenerate the initramfs. The post-install script is located at `ubuntu-generic-diskimages/scripts/post-installation.sh`.

	Make sure the modules are moved before using `gem5-bridge` or compiling benchmarks with `gem5-bridge`:
	Make sure the modules are moved before using `gem5-bridge` or compiling benchmarks with `gem5-bridge`, i.e. add the snippet before the line `echo "Building and installing gem5-bridge (m5) and libm5"`:

		@@ -176,3 +179,16 @@ This document outlines the steps to build a Linux kernel and its modules with th
		### Test with gem5

		- Use the disk image and the kernel to run a gem5 filesystem simulation, ensuring the new kernel and modules are correctly set up.

resources: add scripts to make and extract arm kernel #60

Are you sure you want to change the base?

resources: add scripts to make and extract arm kernel #60

Conversation

Harshil2107 commented Oct 29, 2024

Harshil2107 commented Oct 29, 2024

Choose a reason for hiding this comment

erin-le left a comment

Choose a reason for hiding this comment

Harshil2107 commented Nov 22, 2024

Choose a reason for hiding this comment

Harshil2107 commented Nov 26, 2024

erin-le left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment