Cannot drag sorted column #8
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed bug with dragging sortable columns. After a column was sorted, it could not be dragged to the right. It was possible to drag a column to the left of the sorted column; if the sorted column was subsequently dragged back to the left of the unsorted one, the sorted column would replace the unsorted column and there would be duplicate columns in the grid. When the column is sorted, GWT inserts a div element into the table header, so getting the parent of the target element is not the table row. I simply changed the code that finds the table row to traverse the DOM until the parent tr is found.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed bug with dragging sortable columns. After a column was sorted, it could not be dragged to the right. It was possible to drag a column to the left of the sorted column; if the sorted column was subsequently dragged back to the left of the unsorted one, the sorted column would replace the unsorted column and there would be duplicate columns in the grid.
When the column is sorted, GWT inserts a div element into the table header, so getting the parent of the target element is not the table row. I simply changed the code that finds the table row to traverse the DOM until the parent tr is found.