Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed constraints on operator<=>(optional<T>, U) #55

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Nicholas42
Copy link

operator<=>(std::optional<_Tp>,_Up) was underconstrained. _Up needs to fulfill std::three_way_comparable<_Tp>. See https://gcc.gnu.org/bugzilla/show_bug.cgi?id=98842 and http://eel.is/c++draft/optional#comp.with.t-25.

operator<=>(std::optional<_Tp>,_Up) was underconstrained. _Up needs to fulfill std::three_way_comparable<_Tp>. See https://gcc.gnu.org/bugzilla/show_bug.cgi?id=98842 and http://eel.is/c++draft/optional#comp.with.t-25.
@jwakely
Copy link
Contributor

jwakely commented Jun 11, 2021

This is an unofficial read-only mirror. Creating pull requests here is a waste of time.

Also, your change fails the testsuite.

@jwakely
Copy link
Contributor

jwakely commented Jun 11, 2021

It was fixed properly by adec148

kraj pushed a commit to kraj/gcc that referenced this pull request Jun 8, 2022
This adds type inferencing and validation for arrays such as:

  let x: [i32, 5] = [1,2,3,4,5]
  ley y = [1,2,3];

It checks that each element is of a valid type and they line up correctly.
There needs to be some refactoring of the type resolution to handle the
array index expressions so this is a good save point for now.

Addresses: gcc-mirror#27 gcc-mirror#55
kraj pushed a commit to kraj/gcc that referenced this pull request Jun 8, 2022
Adds new TypeVisitor to resolve Types from the AST via Visitor Pattern, so
the element type can be extracted.

Addresses: gcc-mirror#27 gcc-mirror#55
kraj pushed a commit to kraj/gcc that referenced this pull request Jun 8, 2022
The index expression must be validated to ensure it is an integer.

Addresses: gcc-mirror#27 gcc-mirror#55
kraj pushed a commit to kraj/gcc that referenced this pull request Jun 8, 2022
This compiles the ArrayIndexExpressions and Arrays such as:
  let x = [1,2,3];
  let a = x[0];

Addresses: gcc-mirror#55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants