Fix: Gatsby-Plugin-Offline Double Reload Issue #39042
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gatsbot
bot
added
the
status: triage needed
2 tasks
…pplied to URLs in manifest.webmanifest and HTML head.
…pplied to URLs in manifest.webmanifest and HTML head.
…correctly applied to URLs in manifest.webmanifest and HTML head. Also, address linting issues by correcting string literals and formatting.
…est.webmanifest and HTML head. Ensured correct path handling and resolved linting issues by updating string literals and formatting.
…est.webmanifest and HTML head. Ensured correct path handling and resolved linting issues by updating string literals and formatting.
…est.webmanifest and HTML head. Ensured correct path handling and resolved linting issues by updating string literals and formatting.
…tPrefix and pathPrefix
…tPrefix and pathPrefix
…tPrefix and pathPrefix
…tPrefix and pathPrefix
…tPrefix and pathPrefix
…tPrefix and pathPrefix
…tPrefix and pathPrefix
…tPrefix and pathPrefix
…tPrefix and pathPrefix
…correctly applied to URLs in manifest.webmanifest and HTML head. Also, address linting issues by correcting string literals and formatting.
…correctly applied to URLs in manifest.webmanifest and HTML head. Also, address linting issues by correcting string literals and formatting.
…correctly applied to URLs in manifest.webmanifest and HTML head. Also, address linting issues by correcting string literals and formatting.
…correctly applied to URLs in manifest.webmanifest and HTML head. Also, address linting issues by correcting string literals and formatting.
…tPrefix and pathPrefix
…tPrefix and pathPrefix
…correctly applied to URLs in manifest.webmanifest and HTML head. Also, address linting issues by correcting string literals and formatting.
…correctly applied to URLs in manifest.webmanifest and HTML head. Also, address linting issues by correcting string literals and formatting.
…correctly applied to URLs in manifest.webmanifest and HTML head. Also, address linting issues by correcting string literals and formatting.
…correctly applied to URLs in manifest.webmanifest and HTML head. Also, address linting issues by correcting string literals and formatting.
…correctly applied to URLs in manifest.webmanifest and HTML head. Also, address linting issues by correcting string literals and formatting.
…first reload" --body "This PR addresses issue gatsbyjs#39041 by ensuring that gatsby-plugin-offline provides an offline experience on the first reload without requiring a second reload. Signed-off-by: Emmett Hoolahan <[email protected]>
emmron
force-pushed
the
gatsby-offline-plugin
branch
from
cacc3ef
to
5aaa0bf
Compare
|
@emmron This PR is very large and unwieldy, updates unrelated code, and it isn't clear to me what it's solving. To be honest it looks like it may even have been AI generated, and it looks very similar to #39050. I'm going to close it, but please feel free to open smaller, more easily reviewable PRs. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: The Gatsby-Plugin-Offline requires two reloads to properly cache and serve the index page, causing a blank screen on the second reload.
Solution:
Documentation:
Tests
Related Issues