Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix types on createReadOnly option of snapshotted views #106

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

thegedge
Copy link
Contributor

@thegedge thegedge commented Jul 4, 2024

Verified the added test was failing typechecking before and fixed after

@thegedge thegedge requested a review from scott-rc July 4, 2024 14:03
Copy link

codspeed-hq bot commented Jul 4, 2024

CodSpeed Performance Report

Merging #106 will not alter performance

Comparing fix-snapshotted-view-types (ecf3c59) with main (3dea56c)

Summary

✅ 11 untouched benchmarks

@thegedge thegedge force-pushed the fix-snapshotted-view-types branch from 8015dcf to ecf3c59 Compare July 4, 2024 14:06
Copy link
Contributor

@scott-rc scott-rc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙌

@thegedge
Copy link
Contributor Author

thegedge commented Jul 4, 2024

Still didn't fix the types on gadget main, so I'll keep this up for now and try to understand how to fix those. I think it's something weird about ClassModel[] and how it plays with SnapshotIn

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants