Add NonEmptyList and NonEmptySeq Helper Functions #610
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Perhaps the doc-xml is either malformed or requires an update of fsdocs From https://github.com/fsprojects/FSharpPlus/actions/runs/11390820294/job/31734854875?pr=610 |
cannorin
reviewed
Oct 20, 2024
cannorin
reviewed
Oct 20, 2024
cannorin
reviewed
Oct 20, 2024
cannorin
reviewed
Oct 20, 2024
cannorin
reviewed
Oct 20, 2024
cannorin
reviewed
Oct 20, 2024
cannorin
reviewed
Oct 20, 2024
cannorin
reviewed
Oct 20, 2024
cannorin
reviewed
Oct 20, 2024
cannorin
reviewed
Oct 20, 2024
cannorin
reviewed
Oct 20, 2024
cannorin
reviewed
Oct 20, 2024
devinlyons
force-pushed
the
add-collection-helper-functions
branch
from
6504ecf
to
24ca92d
Compare
gusty
approved these changes
Nov 3, 2024
There was a problem hiding this comment.
Nice job @devinlyons and excellent review by @cannorin
If you want to do more PRs like this, I have somewhere a small lists of collection missing functions from similar collections.
wallymathieu
pushed a commit
that referenced
this pull request
Nov 12, 2024
* Add NonEmptyList helpers to match List. * Add NonEmptySeq helpers to match Seq. * Fix malformed tags in documentation. * Incorporate feedback. * Fix unit tests. * Adjust return types of try* functions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds helper functions to the
NonEmptyListandNonEmptySeqmodules that bring them up to feature parity with theListandSeqmodules.