-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert "-BindReturn" #428
Open
wallymathieu
wants to merge
5
commits into
fsprojects:master
Choose a base branch
from
wallymathieu:revert-applicative
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Revert "-BindReturn" #428
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 78d8835.
gusty
force-pushed
the
master
branch
2 times, most recently
from
August 30, 2022 17:21
32f5c4a
to
f2d1afd
Compare
gusty
force-pushed
the
master
branch
4 times, most recently
from
September 19, 2022 15:20
5c69948
to
9ca5706
Compare
gusty
force-pushed
the
master
branch
2 times, most recently
from
December 2, 2022 10:55
5b61ffc
to
ad56a34
Compare
gusty
force-pushed
the
master
branch
14 times, most recently
from
February 22, 2023 07:56
105ed2c
to
d80a4ad
Compare
wallymathieu
force-pushed
the
master
branch
5 times, most recently
from
February 22, 2023 17:36
f92d910
to
39638fb
Compare
Seems like there are still issues with compiling the code even after |
gusty
force-pushed
the
master
branch
6 times, most recently
from
October 15, 2023 05:01
9b34ece
to
b2f3c8c
Compare
Although the F# compiler issue mentioned in the initial description was solved it seems there was another regression in 5.0 and the following script breaks:
This works in 4.7 but as from 5.0 it throws:
So, a minimal repro should be made in order to report this other regression that happened apparently also at 5.0 |
gusty
force-pushed
the
master
branch
2 times, most recently
from
December 18, 2023 08:18
484cff5
to
142c806
Compare
gusty
force-pushed
the
master
branch
6 times, most recently
from
September 18, 2024 07:45
eef4e98
to
f2e49ba
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 78d8835.
The problem with reverting the commit is that some of the functionality breaks. See the #if APPLICATIVE_FIX sections.
This should be fine to merge once the F# issue:
dotnet/fsharp#10379
Is fixed