Revert the mandatory order of precedence; display PendingDeprecationWarning #778
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carmenbianca
commented
Jun 21, 2023
carmenbianca
force-pushed
the
remove-precedence
branch
2 times, most recently
from
5dae584
to
12790fd
Compare
…arning Signed-off-by: Carmen Bianca BAKKER <[email protected]>
Signed-off-by: Carmen Bianca BAKKER <[email protected]>
Signed-off-by: Carmen Bianca BAKKER <[email protected]>
carmenbianca
force-pushed
the
remove-precedence
branch
from
12790fd
to
b37054d
Compare
linozen
approved these changes
Jun 22, 2023
There was a problem hiding this comment.
These changes are just what we need right now. It uses all the existing logic to revert to aggregation (for now) and can be merged as is IMHO.
Thanks for all your effort @carmenbianca
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See rationale in #779 for reverting this behaviour.