[FS-183852] : Conductor Opentelemetry traces for custom workers #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keerthivaasan-kanagaraj
changed the title
geethalladi
reviewed
Nov 15, 2024
| @@ -38,6 +38,7 @@ plugins { | |||
|
|
|||
| // Establish version and status | |||
| ext.githubProjectName = rootProject.name // Change if github project name is not the same as the root project's name | |||
| version = '3.15.0-FS' | |||
There was a problem hiding this comment.
What version is this ? Can we add more details in the variable names ?
There was a problem hiding this comment.
Since I am modifying the conductor code, the jar created with this 3.15.0 version of conductor code I have added "-FS" suffix to it to denote used for freshservice.
geethalladi
reviewed
Nov 15, 2024
| @@ -23,6 +23,9 @@ dependencies { | |||
| implementation "javax.ws.rs:javax.ws.rs-api:${revJAXRS}" | |||
| implementation "org.glassfish.jersey.core:jersey-common:${revJerseyCommon}" | |||
|
|
|||
| implementation "io.opentelemetry:opentelemetry-extension-annotations:1.18.0" | |||
There was a problem hiding this comment.
Kindly move this to variable, like the above line.
geethalladi
reviewed
Nov 15, 2024
| * LEASE_EXTEND_DURATION_FACTOR), | ||
| TimeUnit.SECONDS); | ||
| leaseExtendMap.put(task.getTaskId(), leaseExtendFuture); | ||
| Map<String, String> headers = new HashMap<>(); |
There was a problem hiding this comment.
- Extract this to a separate method
- We can add an around aspect for adding the trace. KIndly check that
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request type
./gradlew generateLock saveLockto refresh dependencies)NOTE: Please remember to run
./gradlew spotlessApplyto fix any format violations.Changes in this PR
Describe the new behavior from this PR, and why it's needed
Issue #
Alternatives considered
Describe alternative implementation you have considered