fix: Multiple Fixes in Gross Profit Report #44467
Merged
+31
−34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ruthra-kumar
added
backport version-14-hotfix
This was referenced Dec 3, 2024
ruthra-kumar
added a commit
that referenced
this pull request
Dec 3, 2024
…-44467 fix: Multiple Fixes in Gross Profit Report (backport #44467)
ruthra-kumar
added a commit
that referenced
this pull request
Dec 3, 2024
…-44467 fix: Multiple Fixes in Gross Profit Report (backport #44467)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Correct buying amount for a product bundle.
The buying amount was incorrect for the product bundle because it was always set on the basis of the average due to missing keys required for calculating the buying amount from Stock Ledger Entry.
SLE:
Before:
After:
Fixed Data Inconsistency
Instead of using Product Bundle Details, Packed Item details are used for grouped invoices.
This helps in consistency and performance
Performance Fixes
Frappe Support Issue:
https://support.frappe.io/app/hd-ticket/24113
https://support.frappe.io/app/hd-ticket/20809
https://support.frappe.io/app/hd-ticket/23693
Closes:#42329, #35792, #41302
backport version-15
backport version-14