Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: submit POS Invoice only if the invoice amount is fully paid #43966

Draft
wants to merge 7 commits into
base: develop
Choose a base branch
from
Draft

fix: submit POS Invoice only if the invoice amount is fully paid #43966

wants to merge 7 commits into from
+91 −32

Conversation

Navin-S-R
Copy link
Contributor

@Navin-S-R Navin-S-R commented Nov 4, 2024 •
edited
Loading

@Navin-S-R Navin-S-R mentioned this pull request Nov 4, 2024
Open
@Navin-S-R Navin-S-R marked this pull request as draft November 4, 2024 10:43
@ruthra-kumar
Copy link
Member

@Navin-S-R

There are some test failures https://github.com/frappe/erpnext/actions/runs/11662202624/job/32468088817?pr=43966

@Navin-S-R
Copy link
Contributor Author

@ruthra-kumar
Yes the failed patch is related to loyalty point redemption, I'm fixing it.

@uc77 uc77 mentioned this pull request Nov 7, 2024
Closed
@Navin-S-R Navin-S-R marked this pull request as ready for review November 12, 2024 06:01
@Navin-S-R Navin-S-R marked this pull request as draft November 12, 2024 11:42
@ruthra-kumar ruthra-kumar self-assigned this Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deepeshgarg007 deepeshgarg007 Awaiting requested review from deepeshgarg007

@rohitwaghchaure rohitwaghchaure Awaiting requested review from rohitwaghchaure rohitwaghchaure is a code owner

@ruthra-kumar ruthra-kumar Awaiting requested review from ruthra-kumar ruthra-kumar is a code owner

Assignees

@ruthra-kumar ruthra-kumar

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Navin-S-R @ruthra-kumar @sudarsan2001