Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup jail_exists #43

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

vbotka
Copy link
Contributor

@vbotka vbotka commented Sep 7, 2021

  • Update jail_exists. Returns boolean. Check create/absent only. Other comments removed.
  • Change elif after break to if
  • Remove todo in check_mode: use facts to check if basejail would have
    been created before. Out of scope. A play will fail if clone_from is missing.
  • Fix f-string
  • Fix number of returned parameters
  • Fix redundant parenthesis

Tested (in the branch current)

shell> ANSIBLE_SHOW_CUSTOM_STATS=true ansible-playbook iocage_test.yml -M . -e @extra_vars/defaults.yml

test_23:   a1: Sep 07 00:22:14  a2: Sep 07 00:29:59  ok: 58

* Update jail_exists. Returns boolean. Check create/absent only. Other comments removed.
* Change elif after break to if
* Remove todo in check_mode: use facts to check if basejail would have
  been created before. Out of scope. A play will fail if clone_from is
  missing.
* Fix f-string
* Fix number of returned parameters
* Fix redundant parenthesis
@vbotka
Copy link
Contributor Author

vbotka commented Nov 11, 2024

Dear Johannes,

Let's proceed here. Quoting:

From: "Johannes J. Meixner" <sanitized>
To: [email protected]
Subject: Your contributions to fractalcells/ansible-iocage
Date: Mon, 11 Nov 2024 07:46:45 +0100
User-Agent: Mozilla Thunderbird

Dear Vladimir
Thanks for your contributions to ansible-iocage - I did not use it much
in the last few years so they fell off the radar.
https://github.com/fractalcells/ansible-iocage/pulls
Contribute to fractalcells/ansible-iocage development by creating an
account on GitHub.
github.com
Pull requests · fractalcells/ansible-iocage <#>
Contribute to fractalcells/ansible-iocage development by creating an
account on GitHub.
🔗 https://github.com/fractalcells/ansible-iocage/pulls
https://github.com/fractalcells/ansible-iocage/pulls
 Now after merging another PR to fix some null/None issue from last
week, I notice they're conflicting.
Do you still use it, and would you be interested in fixing up the conflict?
Best regards
Johannes

This one is the only conflict.

<<<<<<<< cleanup-jail_exists
            if re.match(r'(\d+|-)', _jid):
=======
            elif re.match(r'(\d+|-|None)', _jid):
>>>>>>> master
  1. The 'if/elif' makes no difference because matching 'if' breaks the loop.

  2. 'None' shouldn't be the 'JID' option if '-h, --header' is used. See 'iocage list -h'. But, nothing happens if you keep it.

Feel free to resolve it on your own. Preceding PRs say there is no conflict.

Occasionally I use the current branch of my fork
https://github.com/vbotka/ansible-iocage/tree/current

Would you(plural) like to submit it to any collection? Or create a 'community.freebsd' perhaps?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant