Switch to distribution 2.8.3 #32
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Encapsulate the compose app manifest creation functionality in a separate file and object. Use the empty descriptor as a value of the app manifest config field as the OCI image specification instructs. Signed-off-by: Mike Sul <[email protected]>
Minimize dependencies on the `distribution` code in the code that generates the non-OCI compliant manifest containing metadata about all app layers. For some reason, the manifest type was defined as an image index while it is actually is an image manifest since it contains layers. We cannot change the manifest media format because older versions of aklite depends on it. And the newer version of `distribution` code checks consistency of the format. So, this code actually fails if the newer version of `distribution` is used. This change removes dependency on `distribution` hence no failure occurs even if a newer version of `distribution` is used. Signed-off-by: Mike Sul <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.