Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Bengali (বাংলা) #930

Merged
merged 4 commits into from
Sep 14, 2024
Merged

Conversation

saifshahriar
Copy link
Contributor

I don't have any experience with rust. :(
Pleases verify my changes to the rust codes.
Also, I wanted to add two aliases for the language 'Bengali': 'bengali', 'বাংলা'. Since I couldn't find a way to do so, I kept only the first one.

@fosskers
Copy link
Owner

fosskers commented Sep 12, 2024

Fantastic, thanks a lot for this. I will install a Bengali font and then test this 😆

There is indeed a way to add multiple aliases. I will fix that for you.

@saifshahriar
Copy link
Contributor Author

saifshahriar commented Sep 13, 2024

Thank you. Also, could you please append the flag 🇧🇩 in readme?

Kindly, try it inside Konsole terminal as it has the least worst support for Bengali fonts.
Please try them with these settings enabled.

Screenshot_20240913_110126

Here, how it might look with the font Hind Siliguri in Konsole:

Screenshot_20240913_105651

Here is how it might look with a Sans version of a Bengali Monospace font Mitra (not Mitra Mono. The monospace variant does not render spaces properly around Bengali fonts):

Screenshot_20240913_110206

Both has a good vowel support for Bengali with the Brahmic Script support turned on. But the spacing is butchered.

Here is how it might look in a minimal terminal like st (JetBrainsMono + Mitra Mono):

Screenshot_20240913_110459

It has good spacing, but no support for Brahmic Script, so the vowels are out of place.

Bengali script is kind of complex, even more than Devanagri/Hindi or Arabic. So, the devs are not interested. Maybe someday we might have an Aura GUI or properly supported terminals.

This is the best font that I have gotten to work with Konsole so far. I don't no how I have this variant in my system. You can find the font here, not sure about the exact variant tough.

Screenshot_20240913_113620

@fosskers
Copy link
Owner

Thanks for those screenshots. I'm going to try it on https://wezfurlong.org/wezterm/ , the terminal I've been using recently.

@fosskers
Copy link
Owner

bengali

Looks good to me.

@fosskers fosskers merged commit 5c1692f into fosskers:master Sep 14, 2024
1 check passed
@fosskers
Copy link
Owner

Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants