Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Preview Chat is now showing up correctly. fixes(#3629) #3630

Closed
wants to merge 1 commit into from
Closed

Preview Chat is now showing up correctly. fixes(#3629) #3630

wants to merge 1 commit into from

Conversation

ashutoshc8101
Copy link
Contributor

@ashutoshc8101 ashutoshc8101 commented Dec 27, 2020 •
edited
Loading

Fixes #3629

Changes:

  • Preview Chat is now showing correctly.

Demo Link: https://pr-3630-fossasia-susi-web-chat.surge.sh

Screenshots of the change:
Capture

@ashutoshc8101
Copy link
Contributor Author

@akshatnitd @Dilshaad21 Please review.

Dilshaad21
Dilshaad21 suggested changes Jan 1, 2021
View reviewed changes
Copy link
Member

@Dilshaad21 Dilshaad21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, bring up the susi.ai chat icon which is going beyond the bottom screen

@ashutoshc8101
Copy link
Contributor Author

ashutoshc8101 commented Jan 2, 2021 •
edited
Loading

@Dilshaad21 I have performed the required changes. Now chat icon button is displayed as expected.
Screenshot from 2021-01-03 18-21-52
Screenshot from 2021-01-03 18-22-14

@ashutoshc8101
Copy link
Contributor Author

@akshatnitd Please review.

akshatnitd
akshatnitd reviewed Jan 4, 2021
View reviewed changes
Copy link
Member

@akshatnitd akshatnitd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the Travis failure

@ashutoshc8101
Copy link
Contributor Author

ashutoshc8101 commented Jan 4, 2021 •
edited
Loading

@akshatnitd The travis failure is due to SURGE API TOKEN not being accepted at surge servers. I don't think, I can do something in that case as I don't have access to surge service neither i have made changes to surge_deploy.sh file.
All tests are passing, build is only failing due to surge deployment.
Screenshot from 2021-01-04 18-31-35

@ashutoshc8101
Copy link
Contributor Author

ashutoshc8101 commented Feb 9, 2021 •
edited
Loading

@akshatnitd Please review. The build is passing now. The issue was with the surge. I removed the surge deployment.
Instead, I deployed my previewFix branch of the forked repository on vercel.

🔍 Inspect: https://vercel.com/ashutoshc8101/susi-ai/gld8n2c57
✅ Preview: https://susi-ai-git-previewfix.ashutoshc8101.vercel.app

@ashutoshc8101 ashutoshc8101 mentioned this pull request Mar 8, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Dilshaad21 Dilshaad21 Dilshaad21 requested changes

@akshatnitd akshatnitd Awaiting requested review from akshatnitd

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Preview chat not showing up correctly in create skill page
3 participants
@ashutoshc8101 @akshatnitd @Dilshaad21