Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent use of indentation in docs/installation/local.md #7619

Closed
ashutoshc8101 opened this issue Jan 18, 2021 · 4 comments
Closed

Inconsistent use of indentation in docs/installation/local.md #7619

ashutoshc8101 opened this issue Jan 18, 2021 · 4 comments

Comments

@ashutoshc8101
Copy link

Describe the bug

Indentation is inconsistent in docs/installation/local.md file

To Reproduce
Steps to reproduce the behavior:

  1. Open docs/installation/local.md
  2. Scroll to poetry section.

Expected behavior
Consistent indentation

Screenshot
issue

@ria-19
Copy link

ria-19 commented Mar 8, 2021

Can I work on this issue?

@iamareebjamal
Copy link
Member

Yes, we don't review PRs for issues which are extremely low priority and which are not endorsed or triaged by the maintainers themselves. If you want your PR to be reviewed, please checkout issues labeled codeheat or created by the project maintainers. People have strange notion about open source that they can open any issue they want and send any PR and maintainers have to give time to review and merge them like it's their job

@MeghalBisht
Copy link
Member

@ashutoshc8101 Why don't you consider rephrasing your comment with less garbage words in it?

@iamareebjamal
Copy link
Member

I cannot comment about SUSI, as I am not a maintainer there. About your PRs here, #7705 is important and will be merged once we have cleared more important PRs before it. A rule of thumb, consider the PRs with no comment from maintainers are of least priority. As for #7705, I commented go ahead means I will eventually merge it. Your PR cannot be merged by just me seeing the code changes. I have to locally pull and run every command to verify if it works or not. And let's say it takes 30 minutes in the process. Right now, I'd rather spend those 30 minutes in fixing a bug which prevents people from editing the profile rather than a PR which changes the system to flask script.

This is same for PR converting the project to poetry from pip. But I merged it because the script was covered by tests. Your PR changes are not covered by tests, so I have no idea without manual testing if it will break the system. And guess what, even when poetry changes were covered by tests, after I merged it, I spent an entire day fixing the deployment failures and side effect bugs which came with it

For you, it's just one PR, for me, it's a potential system breakage that can happen if I merge it without thoroughly testing, and I simply don't have enough time to do it currently when there are actual usability bugs in the system to be addressed.

Your PR has been open for a month? Guess what, my PRs to prominent projects like django projects have been open for years. I have had to fork projects when they don't merge my PRs. And those are PRs with new features and fixes with 100% code coverage. That's how open source is, buddy. I'll merge your PR once I get time to test it or it has code coverage over the changes you have made. Till then, my focus will be on higher priority bugs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants