Fix failing tests #322

AviGawande · 2024-09-11T12:32:33Z

This PR fixes the failing tests when raised a PR or committed changes into the base branch due to some internal conflicts.

Summary by Sourcery

Fix the failing tests by updating GitHub Actions workflows to handle private repository access and adjust system package installations.

CI:

Update GitHub Actions workflows to configure Git for cloning private repositories using a GitHub token.
Modify the installation of Python dependencies in style and flake8 workflows to include a private repository using a GitHub token.

* Add plugins to autodeployment with docker

* Implement option to add link to privacy policy

* add footer link for event + organizer

* Replace pkg_resources with import importlib_metadata

* Do not repeat questions in form field of ticket form

* implement customer feature * implement customer SSO provider & client * add docs for customer functions

* Use master branch in docker-pr workflow * Update workflow test postgres version to 12

* fix-252: Adapt design of ticketing pages to match talk component --------- Co-authored-by: Mario Behling <[email protected]> Co-authored-by: Tri Truong <[email protected]> Co-authored-by: lcduong <[email protected]>

…mplate if eventyay video is installed (fossasia#270)

…ossasia#276)

… before (fossasia#277) * implement script to create customer account for customer placed order before

* update popup content when user join online event

* update join_online_event placeholder * update mobile view for ticket layout

fossasia#289) * add space between notification and header * update translation for menu bar * remove duplicate messageid

* update translation for user dropdown menu

* update dummy data and update link to eventyay.com * update git workflow * update docs --------- Co-authored-by: lcduong <[email protected]>

Rename Wikimania Katowice to a variable for {event}

* Unified QR response * Added EventName to the Unified QR field

sourcery-ai · 2024-09-11T12:32:47Z

Reviewer's Guide by Sourcery

This pull request addresses failing tests in the CI pipeline by updating GitHub Actions workflows. The changes primarily focus on improving the setup for private repository access, updating system dependencies, and modifying the installation process for Python packages.

File-Level Changes

Change	Details	Files
Improve GitHub Actions workflow for running tests	Add step to set up Git for cloning private repositories Update formatting of branch names in workflow triggers Add more detailed steps for installing dependencies and running tests Improve caching and error handling in the workflow	`.github/workflows/tests.yml`
Update dependency installation in style check workflows	Add installation of a private GitHub repository using a token Update pip install commands to include the private repository	`.github/workflows/style.yml`
Update system package installation in documentation and string check workflows	Replace 'enchant' with 'libenchant-2-2' in system package installation	`.github/workflows/docs.yml` `.github/workflows/strings.yml`

Tips

Trigger a new Sourcery review by commenting @sourcery-ai review on the pull request.
Continue your discussion with Sourcery by replying directly to review comments.
You can change your review settings at any time by accessing your dashboard:
- Enable or disable the Sourcery-generated pull request summary or reviewer's guide;
- Change the review language;
You can always contact us if you have any questions or feedback.

sourcery-ai

Hey @AviGawande - I've reviewed your changes and they look great!

Here's what I looked at during the review

🟢 General issues: all looks good
🟡 Security: 2 issues found
🟢 Testing: all looks good
🟢 Complexity: all looks good
🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

_{Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.}

sourcery-ai · 2024-09-11T12:33:50Z

.github/workflows/tests.yml

@@ -25,39 +25,54 @@ jobs:
            python-version: 3.11
    steps:
      - uses: actions/checkout@v2
+
+      # Set up Git for cloning private repositories
+      - name: Set up Git for cloning private repositories


🚨 suggestion (security): Consider using GitHub's built-in GITHUB_TOKEN for improved security

Instead of using a custom GH_TOKEN, consider using the built-in GITHUB_TOKEN which is automatically created for each workflow run and has the necessary permissions. This would eliminate the need to manage a separate secret and reduce potential security risks.

- name: Set up Git for cloning private repositories run: | git config --global url."https://${{ github.token }}@github.com/".insteadOf "https://github.com/"

sourcery-ai · 2024-09-11T12:33:50Z

.github/workflows/style.yml

-        run: pip3 install -e ".[dev]" psycopg2-binary
+        run: |
+          pip3 install -e ".[dev]" psycopg2-binary
+          pip3 install git+https://${{ secrets.GITHUB_TOKEN }}:[email protected]/fossasia/eventyay-tickets-stripe.git@master


🚨 suggestion (security): Consider using a more secure method for installing private packages

While using GITHUB_TOKEN is better than a custom token, consider using a more secure method for installing private packages. You could use GitHub Packages or a private PyPI server, which would provide better access control and versioning.

- name: Install dependencies run: | pip3 install -e ".[dev]" psycopg2-binary pip config set global.extra-index-url https://github-package-registry.fossasia.org/ pip3 install eventyay-tickets-stripe env: PIP_EXTRA_INDEX_URL: https://github-package-registry.fossasia.org/

Great! I'm glad you were able to address the suggestion. Using a more secure method for installing private packages is definitely a good practice. If you have any further questions or need additional assistance, feel free to ask. Keep up the good work!

mariobehling · 2024-10-10T05:05:35Z

It would be great if you fix the latest code of the project and resolve the conflicts.

AviGawande and others added 30 commits August 15, 2024 15:42

Add plugins to autodeployment with docker (fossasia#208)

c1ac364

* Add plugins to autodeployment with docker

Implement option to add link to privacy policy (fossasia#227)

37815b8

* Implement option to add link to privacy policy

Option to add customizable links to footer (fossasia#225)

9f4459b

* add footer link for event + organizer

Replace pkg_resources (fossasia#232)

10623c5

* Replace pkg_resources with import importlib_metadata

Do not repeat questions in form field of ticket form (fossasia#235)

52d2dbd

* Do not repeat questions in form field of ticket form

Added templates (fossasia#229)

df5bd17

Implement customer accounts in system (fossasia#223)

2935ae7

* implement customer feature * implement customer SSO provider & client * add docs for customer functions

change default color for new organization (fossasia#240)

2b3dd01

Use master branch in docker-pr workflow (fossasia#243)

45e439a

* Use master branch in docker-pr workflow * Update workflow test postgres version to 12

fix issue when send mail to invite member (fossasia#244)

831563c

Allows tab IDs to be set in the HTML code (fossasia#247)

060c00c

skip check for empty country (fossasia#246)

1f3200a

Revoked devices to be removed from device list (fossasia#249)

d96421b

Email template: Add {Join online event} placeholder into the email te…

8c9f3ca

…mplate if eventyay video is installed (fossasia#270)

handle case allow all ticket to join (fossasia#271)

20ef04e

Implement token for the Join online event button on the ticket page (f…

bdc783c

…ossasia#276)

Implement script to create customer account for customer placed order…

1c4dedc

… before (fossasia#277) * implement script to create customer account for customer placed order before

Update content in join video online popup (fossasia#278)

80a795b

* update popup content when user join online event

stay on same tab when click menu (fossasia#281)

afee55c

implement API to check if user paid for event or not (fossasia#280)

5d89008

update join_online_event placeholder (fossasia#284)

0a6c27d

update content of popup when join online event (fossasia#283)

7b4de19

Fix join online button layout (fossasia#286)

7bf4c94

* update join_online_event placeholder * update mobile view for ticket layout

add space between notification and header (fossasia#288)

8895464

Add translations of menu schedule, session, tickets, join video online (

e63cad4

fossasia#289) * add space between notification and header * update translation for menu bar * remove duplicate messageid

localize and login should be in same line

3af1b5d

update token key

80c867c

Update translation for user dropdown menu (fossasia#295)

d2e62fb

* update translation for user dropdown menu

Update dummy test data (fossasia#298)

7e59313

* update dummy data and update link to eventyay.com * update git workflow * update docs --------- Co-authored-by: lcduong <[email protected]>

lcduong and others added 7 commits August 20, 2024 06:20

specify the version of psycopg2 (fossasia#296)

668389d

Rename Wikimania Katowice to a variable for {event}

e40c303

Use translation placeholders instead of split strings

0d5e2d2

format po file

192aba3

Merge pull request fossasia#303 from lcduong/feature-302

b4217cd

Rename Wikimania Katowice to a variable for {event}

Unified QR response (fossasia#304)

f473ee4

* Unified QR response * Added EventName to the Unified QR field

fix tests failure

f74d069

sourcery-ai bot reviewed Sep 11, 2024

View reviewed changes

AviGawande added 2 commits September 11, 2024 18:09

update-config

4638e0a

fixed-github-token

2decf4d

odkhang force-pushed the development branch from 98d72f5 to 69a456a Compare September 24, 2024 07:45

odkhang force-pushed the development branch from 6f05d43 to 9db4d89 Compare October 10, 2024 08:09

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix failing tests #322

Fix failing tests #322

AviGawande commented Sep 11, 2024 •

edited by sourcery-ai bot

Loading

sourcery-ai bot commented Sep 11, 2024 •

edited

Loading

sourcery-ai bot left a comment

sourcery-ai bot Sep 11, 2024

sourcery-ai bot Sep 11, 2024

AviGawande Sep 11, 2024

sourcery-ai bot Sep 11, 2024

mariobehling commented Oct 10, 2024

Fix failing tests #322

Are you sure you want to change the base?

Fix failing tests #322

Conversation

AviGawande commented Sep 11, 2024 • edited by sourcery-ai bot Loading

Summary by Sourcery

sourcery-ai bot commented Sep 11, 2024 • edited Loading

Reviewer's Guide by Sourcery

File-Level Changes

sourcery-ai bot left a comment

Choose a reason for hiding this comment

sourcery-ai bot Sep 11, 2024

Choose a reason for hiding this comment

sourcery-ai bot Sep 11, 2024

Choose a reason for hiding this comment

AviGawande Sep 11, 2024

Choose a reason for hiding this comment

sourcery-ai bot Sep 11, 2024

Choose a reason for hiding this comment

mariobehling commented Oct 10, 2024

AviGawande commented Sep 11, 2024 •

edited by sourcery-ai bot

Loading

sourcery-ai bot commented Sep 11, 2024 •

edited

Loading