Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(a380x/fcu): add correct QFE label using baro preselect #9637

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

heclak
Copy link
Contributor

@heclak heclak commented Dec 8, 2024

Fixes #[issue_no]

Summary of Changes

  • add QFE label using baro preselect
  • add characters q,f,e and test q to FCU font
  • clean up old QFE label
  • adjust the alignment and size of elements in the baro window
  • edit the 7-segment digits/character in the FCU font to sit on the correct baseline
  • edit styling of all FCU digits to match changes in new font scale

Screenshots (if necessary)

image
image

References

image
image

Additional context

Discord username (if different from GitHub): Heclak

Testing instructions

  1. Turn on ANN LT to test and compare to screenshot/reference above for light test mode.
  2. Testing the QFE label would require the use of behaviour debug tool to trigger as there is no in-cockpit method to switch to QFE mode yet. You can set XMLVAR_Baro1_Mode to 0 to switch baro mode to 0.
  3. Turn all the FCU controls to create all the various 7-segment digit combinations, TRK/FPA mode, light test, etc to check that the edited 7-segment font is correctly implemented.

image

How to download the PR for QA

Every new commit to this PR will cause new A32NX and A380X artifacts to be created, built, and uploaded.

  1. Make sure you are signed in to GitHub
  2. Click on the Checks tab on the PR
  3. On the left side, find and click on the PR Build tab
  4. Click on either flybywire-aircraft-a320-neo, flybywire-aircraft-a380-842 (4K) or flybywire-aircraft-a380-842 (8K) download link at the bottom of the page

* add QFE label using baro preselect
* add characters q,f,e and test q to FCU font
* clean up old QFE label
* adjust the alignment and size of elements in the baro window
@BravoMike99 BravoMike99 requested a review from tracernz December 8, 2024 12:36
Copy link
Member

@tracernz tracernz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@BravoMike99
Copy link
Contributor

Quality Assurance TesterReport

Discord Username : bruno_pt99
Object of testing : #9637
Aircraft : A380X
Tier of Testing : 1
Date : 09/12/2024

Testing Process:

  1. Performed a light test and verified the preselect text matches the screenshot and ref picture ✔️
  2. Changed the barometric mode to QFE through the dev menu and noticed the QFE font seems slightly cutout vs the screenshot above & ref pic ❌

Testing Results:
Not Passed

Media:
LT Test
QFE

@heclak
Copy link
Contributor Author

heclak commented Dec 10, 2024

@BravoMike99 ah darn. It looks like my workaround is flawed. I guess redrawing the font file to font standards might be needed. I was trying to avoid that as that means redoing all the font sizes for all the FCU fonts. I'll work on this and come back with an update.

Thanks for testing and finding this

@BravoMike99
Copy link
Contributor

@BravoMike99 ah darn. It looks like my workaround is flawed. I guess redrawing the font file to font standards might be needed. I was trying to avoid that as that means redoing all the font sizes for all the FCU fonts. I'll work on this and come back with an update.

Thanks for testing and finding this

Weirdly enough when I opened the debugger and "hovered" over the FCU display, it would show the QFE properly just like your screenshot

@heclak
Copy link
Contributor Author

heclak commented Dec 10, 2024

Weirdly enough when I opened the debugger and "hovered" over the FCU display, it would show the QFE properly just like your screenshot

@BravoMike99 It's a legitimate bug because it's an issue with the font file. When the font was originally created, it appear to be made with the baseline in the wrong location. So there is no room for the descender (eg the bottom of a q, g, etc). I worked around by exporting a non-validated font and it seemed to have worked initially. However, because part of that tail is outside of the font's HTML area, the tail doesn't get refreshed correctly all the time. Sometimes the text is hidden but the tail remains, sometimes the text is drawn but the tail is forgotten. I didn't notice this issue until you pointed it out. I researched about extending the render area but it seems the only way to have it work reliably is to remake the font with the correct specifications.

…t font baseline

* edited all 7-segment fonts in the FCU font to follow the correct font baseline non-7segment characters are untouched)
*  adjusted all FCU digits to the new FCU font
@heclak
Copy link
Contributor Author

heclak commented Dec 11, 2024

I've redone the 7-segment fonts to the correct font baseline. This font file is now validated and will fix the issue with the cutoff Q in the previous QA test. However, this fix required me to retouch all the 7-segment digits in the FCU and will require a more careful test of all the 7-segment digit functions in QA (baro window, SPD, HDG, ALT, VS). Please turn all the possible FCU digits to check that alignment and digit combinations all work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: 🟣 QA Review: Ready to Test
Development

Successfully merging this pull request may close these issues.

3 participants