-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(a380x/fcu): add correct QFE label using baro preselect #9637
base: master
Are you sure you want to change the base?
feat(a380x/fcu): add correct QFE label using baro preselect #9637
Conversation
* add QFE label using baro preselect * add characters q,f,e and test q to FCU font * clean up old QFE label * adjust the alignment and size of elements in the baro window
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
Quality Assurance TesterReport Discord Username : bruno_pt99 Testing Process:
Testing Results: |
@BravoMike99 ah darn. It looks like my workaround is flawed. I guess redrawing the font file to font standards might be needed. I was trying to avoid that as that means redoing all the font sizes for all the FCU fonts. I'll work on this and come back with an update. Thanks for testing and finding this |
Weirdly enough when I opened the debugger and "hovered" over the FCU display, it would show the QFE properly just like your screenshot |
@BravoMike99 It's a legitimate bug because it's an issue with the font file. When the font was originally created, it appear to be made with the baseline in the wrong location. So there is no room for the descender (eg the bottom of a q, g, etc). I worked around by exporting a non-validated font and it seemed to have worked initially. However, because part of that tail is outside of the font's HTML area, the tail doesn't get refreshed correctly all the time. Sometimes the text is hidden but the tail remains, sometimes the text is drawn but the tail is forgotten. I didn't notice this issue until you pointed it out. I researched about extending the render area but it seems the only way to have it work reliably is to remake the font with the correct specifications. |
…t font baseline * edited all 7-segment fonts in the FCU font to follow the correct font baseline non-7segment characters are untouched) * adjusted all FCU digits to the new FCU font
I've redone the 7-segment fonts to the correct font baseline. This font file is now validated and will fix the issue with the cutoff Q in the previous QA test. However, this fix required me to retouch all the 7-segment digits in the FCU and will require a more careful test of all the 7-segment digit functions in QA (baro window, SPD, HDG, ALT, VS). Please turn all the possible FCU digits to check that alignment and digit combinations all work. |
Fixes #[issue_no]
Summary of Changes
Screenshots (if necessary)
References
Additional context
Discord username (if different from GitHub): Heclak
Testing instructions
How to download the PR for QA
Every new commit to this PR will cause new A32NX and A380X artifacts to be created, built, and uploaded.