-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(a380x/fma): disconnect ap for ldg message #9606
Open
BravoMike99
wants to merge
1
commit into
flybywiresim:master
Choose a base branch
from
BravoMike99:380-disco-ap-for-ldg
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+99
−27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flogross89
approved these changes
Dec 1, 2024
tracernz
requested changes
Dec 2, 2024
Comment on lines
+74
to
+96
private readonly radioHeightConsumer = ConsumerSubject.create(this.sub.on('chosenRa'), Arinc429Word.empty()); | ||
|
||
private readonly altitudeConsumer = ConsumerSubject.create(this.sub.on('altitudeAr'), Arinc429Word.empty()); | ||
|
||
private readonly landingElevation = ConsumerSubject.create( | ||
this.sub.on('landingElevation').whenChanged(), | ||
Arinc429Word.empty(), | ||
); | ||
|
||
private readonly ap1Consumer = ConsumerSubject.create(this.sub.on('ap1Active').whenChanged(), false); | ||
|
||
private readonly ap2Consumer = ConsumerSubject.create(this.sub.on('ap2Active').whenChanged(), false); | ||
|
||
private readonly verticalModeConsumer = ConsumerSubject.create(this.sub.on('activeVerticalMode').whenChanged(), 0); | ||
|
||
private readonly selectedVerticalSpeed = ConsumerSubject.create(this.sub.on('apVsSelected').whenChanged(), null); | ||
|
||
private readonly selectedFpa = ConsumerSubject.create(this.sub.on('selectedFpa').whenChanged(), null); | ||
|
||
private readonly approachCapabilityConsumer = ConsumerSubject.create( | ||
this.sub.on('approachCapability').whenChanged(), | ||
0, | ||
); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
.whenChanged is redundant, and we don't do Hungarian notation (that's the part I request mandatory changes for). I suggest some names like the following (also for additional clarity).
Suggested change
private readonly radioHeightConsumer = ConsumerSubject.create(this.sub.on('chosenRa'), Arinc429Word.empty()); | |
private readonly altitudeConsumer = ConsumerSubject.create(this.sub.on('altitudeAr'), Arinc429Word.empty()); | |
private readonly landingElevation = ConsumerSubject.create( | |
this.sub.on('landingElevation').whenChanged(), | |
Arinc429Word.empty(), | |
); | |
private readonly ap1Consumer = ConsumerSubject.create(this.sub.on('ap1Active').whenChanged(), false); | |
private readonly ap2Consumer = ConsumerSubject.create(this.sub.on('ap2Active').whenChanged(), false); | |
private readonly verticalModeConsumer = ConsumerSubject.create(this.sub.on('activeVerticalMode').whenChanged(), 0); | |
private readonly selectedVerticalSpeed = ConsumerSubject.create(this.sub.on('apVsSelected').whenChanged(), null); | |
private readonly selectedFpa = ConsumerSubject.create(this.sub.on('selectedFpa').whenChanged(), null); | |
private readonly approachCapabilityConsumer = ConsumerSubject.create( | |
this.sub.on('approachCapability').whenChanged(), | |
0, | |
); | |
private readonly radioHeight = ConsumerSubject.create(this.sub.on('chosenRa'), Arinc429Word.empty()); | |
private readonly altitude = ConsumerSubject.create(this.sub.on('altitudeAr'), Arinc429Word.empty()); | |
private readonly landingElevation = ConsumerSubject.create( | |
this.sub.on('landingElevation'), | |
Arinc429Word.empty(), | |
); | |
private readonly ap1Active = ConsumerSubject.create(this.sub.on('ap1Active'), false); | |
private readonly ap2Active = ConsumerSubject.create(this.sub.on('ap2Active'), false); | |
private readonly activeVerticalMode = ConsumerSubject.create(this.sub.on('activeVerticalMode'), 0); | |
private readonly selectedVerticalSpeed = ConsumerSubject.create(this.sub.on('apVsSelected'), null); | |
private readonly selectedFpa = ConsumerSubject.create(this.sub.on('selectedFpa'), null); | |
private readonly approachCapability = ConsumerSubject.create( | |
this.sub.on('approachCapability'), | |
0, | |
); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #[issue_no]
Summary of Changes
Adds the "DISCONNECT AP FOR LDG" FMA message on PFD.
Screenshots (if necessary)
References
Additional context
Discord username (if different from GitHub):
bruno_pt99
Testing instructions
How to download the PR for QA
Every new commit to this PR will cause new A32NX and A380X artifacts to be created, built, and uploaded.