Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: enforce closing of doors when tug is attached #9602

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

frankkopp
Copy link
Member

@frankkopp frankkopp commented Nov 29, 2024

Fixes #9405

Summary of Changes

Addresses issues with open doors especially when users use GSX which seem to have trouble closing some of the doors again.

This PR ensures doors are closed when the tug is attached, the aircraft moves or is not on ground.

Additional context

Check if this clashes with #9528 or the GSX support in general (although it addresses the issue that GSX is not able to handle higher door indexes).

Discord username (if different from GitHub): cdr_maverick

Testing instructions

Needs testing in both aircraft (A32NX and A380X).
Try to get into a state that doors stay open once pushback is attached or when in the air.
Especially if you have GSX test that this does not interfere with the GSX integration.

How to download the PR for QA

Every new commit to this PR will cause new A32NX and A380X artifacts to be created, built, and uploaded.

  1. Make sure you are signed in to GitHub
  2. Click on the Checks tab on the PR
  3. On the left side, find and click on the PR Build tab
  4. Click on either flybywire-aircraft-a320-neo, flybywire-aircraft-a380-842 (4K) or flybywire-aircraft-a380-842 (8K) download link at the bottom of the page

@frankkopp frankkopp added the A380X Related to the A380X aircraft label Nov 29, 2024
@frankkopp frankkopp self-assigned this Nov 29, 2024
@frankkopp frankkopp marked this pull request as ready for review November 29, 2024 01:04
@frankkopp frankkopp added QA Tier 1 A32NX Related to the A32NX aircraft labels Nov 29, 2024
@frankkopp frankkopp changed the title fix: implemented brute force closing of doors when tug is attached fix: enforce closing of doors when tug is attached Nov 30, 2024
@beheh
Copy link
Member

beheh commented Dec 2, 2024

Is this explicitly when the tug is moving? Some people might want to attach the tug a few minutes ahead of push back while boarding is still running, just so it's ready to go later.

@frankkopp
Copy link
Member Author

frankkopp commented Dec 2, 2024

Is this explicitly when the tug is moving? Some people might want to attach the tug a few minutes ahead of push back while boarding is still running, just so it's ready to go later.

It is explicitly when the tug var is showing attached:

[pushBackAttached] = useSimVar('Pushback Attached', 'enum', 250);

Unfortunately this is set to true the moment you call the tug - not when it is actually visually attached.

This is actually how it has been since the beginning of the flyPad Ground pages - I never changed this.
But there was an issue that you had to be on the Ground Services page for it to work and also it only closed the doors controlled by the Services page. This is what this PR fixes - it closes all doors no matter on which flyPad page you are.

I do understand you point but I think using this as trigger is the best solution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A32NX Related to the A32NX aircraft A380X Related to the A380X aircraft Needs Code Review QA Tier 1
Projects
Status: 🟡 Code Review: Ready for Review
Development

Successfully merging this pull request may close these issues.

Baggage & Catering cargo doors on aircraft failed to close
2 participants