Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(nd): Added method to handle Groundspeed display logic #9553

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

MrJigs7
Copy link

@MrJigs7 MrJigs7 commented Nov 18, 2024

Fixes #9545

Summary of Changes

Added method to handle GS display logic
Added method to handle TAS display logic
Set logic for both GS and TAS display - Dashes if NCD, blank if FW, and normal otherwise

Screenshots (if necessary)

Before change
TAS After Change NCD
TAS After Change with Data

References

Picture and discussion on issue 9545

Additional context

Discord username (if different from GitHub):MrJigs

Testing instructions

Spawn on the ground with engines running and observe TAS value being dashed on ND
Takeoff, TAS will display data >60kts
Trigger failure such as ADIRS, TAS and GS will be blank

How to download the PR for QA

Every new commit to this PR will cause new A32NX and A380X artifacts to be created, built, and uploaded.

  1. Make sure you are signed in to GitHub
  2. Click on the Checks tab on the PR
  3. On the left side, find and click on the PR Build tab
  4. Click on either flybywire-aircraft-a320-neo, flybywire-aircraft-a380-842 (4K) or flybywire-aircraft-a380-842 (8K) download link at the bottom of the page

Added method to handle TAS display logic
Set logic for both GS and TAS display - Dashes if NCD, blank if FW, and normal otherwise
@MrJigs7 MrJigs7 changed the title Added method to handle Groundspeed display logic fix(nd): Added method to handle Groundspeed display logic Nov 18, 2024
@2hwk 2hwk added this to the v0.13.0 milestone Nov 21, 2024
@2hwk 2hwk added A32NX Related to the A32NX aircraft A380X Related to the A380X aircraft QA Tier 1 QA Ready to Test labels Nov 21, 2024
@MrJigs7
Copy link
Author

MrJigs7 commented Nov 28, 2024

Do I need to do anything else here before this is checked by QA?

@BravoMike99
Copy link
Contributor

Do I need to do anything else here before this is checked by QA?

Nope, all good for now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A32NX Related to the A32NX aircraft A380X Related to the A380X aircraft QA Ready to Test QA Tier 1
Projects
Status: 🟣 QA Review: Ready to Test
Development

Successfully merging this pull request may close these issues.

ND: GS & TAS values blank if no computed data
3 participants