Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(nd): Updated active waypoint to be left aligned #9547

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

MrJigs7
Copy link

@MrJigs7 MrJigs7 commented Nov 17, 2024

Updated active waypoint to be left aligned
Updated text X position

Fixes [#9472]

Summary of Changes

Updated active waypoint to be left aligned
Updated text X position to correctly display active waypoint on ND.

Screenshots (if necessary)

Before Change
3 character waypoint
5 character waypoint
6 character waypoint
7 character waypoint

References

RealWorld A380 ND

Additional context

Discord username (if different from GitHub):MrJigs

Testing instructions

  1. Load a flight plan, insert some waypoints - make sure not in PPOS
  2. Check active waypoint is now left aligned
  3. Check waypoints of various character lengths to check correct positioning and make sure no fonts clip with other ND details

How to download the PR for QA

Every new commit to this PR will cause new A32NX and A380X artifacts to be created, built, and uploaded.

  1. Make sure you are signed in to GitHub
  2. Click on the Checks tab on the PR
  3. On the left side, find and click on the PR Build tab
  4. Click on either flybywire-aircraft-a320-neo, flybywire-aircraft-a380-842 (4K) or flybywire-aircraft-a380-842 (8K) download link at the bottom of the page

@MrJigs7 MrJigs7 changed the title Updated active waypoint to be left aligned [fix] Updated active waypoint to be left aligned Nov 17, 2024
@MrJigs7 MrJigs7 changed the title [fix] Updated active waypoint to be left aligned Fix:Updated active waypoint to be left aligned Nov 17, 2024
@MrJigs7 MrJigs7 changed the title Fix:Updated active waypoint to be left aligned Fix: Updated active waypoint to be left aligned Nov 17, 2024
@MrJigs7 MrJigs7 changed the title Fix: Updated active waypoint to be left aligned fix(nd): Updated active waypoint to be left aligned Nov 18, 2024
@tracernz
Copy link
Member

tracernz commented Nov 18, 2024

Do you have any A320 family references? You are changing it for both planes here.

-e- this is not correct for the A320, so it will have to be done for A380 only.

@CaptCrystal
Copy link

image
@tracernz I don't know if this was followed for this pr, but here is a reference for the a320neo.

@heclak
Copy link
Contributor

heclak commented Nov 18, 2024

I think this is wrong for the A320 Neo. Based on this reference with a three char waypoint name, I believe it is right aligned on the A320.
image

https://youtu.be/Y1yQziRUFNY?si=RG2w7aXdU0aBFEt1 (3:06)

@tracernz
Copy link
Member

tracernz commented Nov 18, 2024

An appropriate CSS class (with transform rather than the SVG x/y attrs) + different CSS for that class in the ND stylesheet for the A380X might be the easiest way to solve it.

@MrJigs7
Copy link
Author

MrJigs7 commented Nov 18, 2024

An appropriate CSS class (with transform rather than the SVG x/y attrs) + different CSS for that class in the ND stylesheet for the A380X might be the easiest way to solve it.

I am still learning CSS so and my way round the repo so unfortunately I am not 100% sure on how exactly to do this but if a similar change or reference could be provided, I could take a look

@MrJigs7 MrJigs7 marked this pull request as draft November 20, 2024 16:35
@MrJigs7
Copy link
Author

MrJigs7 commented Nov 20, 2024

Had a further look into this, not sure if I am on the right track, in the fbw-common ND is it better to change to render all of the ToWaypointIndicator class using transform or just the toWptIdentValue ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 🟡 Code Review: Ready for Review
Development

Successfully merging this pull request may close these issues.

4 participants