-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: flyPad Checklists refactor and adaption to A380X #8593
feat: flyPad Checklists refactor and adaption to A380X #8593
Conversation
fbw-common/src/systems/instruments/src/EFB/Checklists/Checklists.tsx
Outdated
Show resolved
Hide resolved
fbw-common/src/systems/instruments/src/EFB/Checklists/CompletionButton.tsx
Outdated
Show resolved
Hide resolved
Note: build is failing |
0fda55f
to
bf4507e
Compare
a8f4bc5
to
f585d0c
Compare
f9bd89a
to
3e8a8e2
Compare
…tialize using the actual aircraft checklist as a template. The 'getAircraftType()' function, hard-coded checklist definitions and 'setChecklistItems' action were removed. In their place, a new 'addTrackingChecklists' action was introduced to dynamically add tracking checklists. Further changes were made in `Efb.tsx` to load and process aircraft checklists accordingly.
…tsx of the aircraft EFB class to make sure it is loaded before any component of the EFB is loaded.
…s not relevant for the current flight phase
…80X as not yet working
41b1498
to
1d3010a
Compare
Quality Assurance Trainee Report Discord : PilotEyesA350 Testing Process: Spawn at EDDM Negatives: Testing Results: Conclusions: Media: |
Summary of Changes
This PR brings the flyPad Checklists to the A380X using a slight blend of the A380X paper checklist and A380X ECL lists.
It includes refactoring how checklists are defined using json5 configurations so that multiple aircrafts can be easily defined using a configuration path that can be determined by the aircraft type. The goal is to enable mods to alter these configurations for the users.
It is planned to integrate this with the currently developed unified configuration framework (#8599)
This PR also enhances the data structure of the checklists to allow for checklist lines ("down to the line" and "below the line") and sub checklists as they appear on the A380X ECL. The aim is to reuse these data structures for the ECL once implemented.
The refactoring also impacts the A32NX checklists with little visible changes to the user.
One noticeable change is that automatically checked items are now updated in all checklists not yet completed. Previously these updates were limited to the checklist associated with the current flight phase which was confusing as it then showed completed items as incomplete (or vice versa) in checklists outside the current flight phase without any hint why the status is displayed incorrectly.
Screenshots (if necessary)
References
Reference showing Sublist and Line: https://youtu.be/p28erS6uWHE?t=2514
Discord username (if different from GitHub): cdr_maverick
Testing instructions
A32NX:
Test all checklist using manual and autocompletion mode.
Esp. the auto-complete items should actually show correctly - e.g. PARK BRK ON is complete when parking brake is set.
A380X:
Test all checklist using manual and autocompletion mode.
Esp. the auto-complete items should actually show correctly - e.g. PARK BRK ON is complete when parking brake is set.
How to download the PR for QA
Every new commit to this PR will cause new A32NX and A380X artifacts to be created, built, and uploaded.