Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(a380x/oans): OANS integration for A380X #8564

Merged
merged 711 commits into from
Sep 1, 2024
Merged

feat(a380x/oans): OANS integration for A380X #8564

merged 711 commits into from
Sep 1, 2024

Conversation

flogross89
Copy link
Contributor

@flogross89 flogross89 commented Mar 12, 2024 •
edited
Loading

A380X only.

Summary of Changes

Integration of holland's OANS into the A380X, together with some UI additions for BTV.

Out of scope: Integration of Navigraph's AMDB SDK, to be followed in later PR.

Notes for reviewers

  • I used holland's OANC branch as a basis, and performed the above steps to integrate it in the A380X and enable it for the use together with BTV (along with some other bug fixes and extensions)
  • a380x/fmgc deleted, this is already done in the MFD PR though
  • Uses widgets from the MFD
  • Changes the FCU to isolate it from the a32nx code and enable ZOOM ranges
    Linked review issue for review afterwards: [A380X] Code Review for OANS/OANC #8843

Screenshots (if necessary)

image

References

(https://www.youtube.com/watch?v=p28erS6uWHE)
FCOM
Various references

Discord username (if different from GitHub): floridude

Testing instructions

A32NX: No changes expected for now, just preparational work for integrating OANC in the future. Please play around with the ND, it should behave as normal for different ranges and modes.

How to download the PR for QA

Every new commit to this PR will cause new A32NX and A380X artifacts to be created, built, and uploaded.

  1. Make sure you are signed in to GitHub
  2. Click on the Checks tab on the PR
  3. On the left side, click on the bottom PR tab
  4. Click on either flybywire-aircraft-a320-neo or flybywire-aircraft-a380-842 download link at the bottom of the page

@2hwk
Copy link
Member

2hwk commented Mar 13, 2024

Maybe retarget to fms v2 branch so that code reviewers can see the diff

@flogross89 flogross89 changed the base branch from master to fms-v2 March 13, 2024 21:08
@flogross89
Copy link
Contributor Author

Maybe retarget to fms v2 branch so that code reviewers can see the diff

good point, thanks. changed it.

aguther and others added 20 commits March 17, 2024 21:13
@aguther
Merge branch 'master' into fms-v2
20c9d31
@Saschl
feat: fms-v2 msfs sync (flybywiresim#8508)
5683499 
* add intial sync with all todos and hacks

* serialize dest and origin airports

* fix: guard origin and destination airport in serialization

* fix: waypoint insertion, add extra module for sync

* remove unncecessary change

* use more granular sync events

* some cleanup

* feat: sync flight plan from game

* fix some errors

* more log

* fix: export FlightPlanRpcServer

* fix: mapping

* fix: delay init until ingame

* use native fms2 sync

* fix: missing airport and runway in sync

* Revert "fix: missing airport and runway in sync"

This reverts commit 0d87e5a.

* Revert "use native fms2 sync"

This reverts commit b9f2f1f.

* fix: sync confusion

* small improvement

* enable basic load from sim

* fix: rpcclient creation

* only use rpc client for initial load

* fix: datastore subscription

* fix: enroute waypoint insertion
@Saschl
fix: approach mapping, off by one error and runway selection
3612c22
@Saschl
remove flightPlanTest
17f190b
@Saschl
fix: typing errors
c0cadfa
@Saschl
fix: destination runways without secondary designator
bbfa446
@Saschl
fix: lint
985f247
@Saschl
fix(sync): use sensible defaults if mapping fails
981209b
@Saschl
fix: init issue after fixing other init issue
e9fbdd1
@BlueberryKing
Fix wrong FD leg ident
e366799
@BlueberryKing
Improve arrival and departure pages
48ffe17
@BlueberryKing
Handle explicit NO SID, NO STAR, etc. selection
4221c75
@BlueberryKing
Refactor MPR selection
7947117
@BlueberryKing
Merge remote-tracking branch 'upstream/master' into fms-v2
65339fe
@BlueberryKing
Merge branch 'fms-v2' of https://github.com/flybywiresim/aircraft int…
a833eff 
…o fms-v2
@BlueberryKing
Fix missing disco after leg deletion in alternate
803deb3
@BlueberryKing
Remove arrival procedures after changing alternate
1123df5
@BlueberryKing
Dump entire alternate plan when changing altn dest
5217910
@Saschl
feat: load MSFS flightplan in "SAVE" mode too
5aef002
@BlueberryKing
Remove commented code
5c0c395
@tylerclt
Copy link

Quality Assurance Trainee Report

Discord: Tylerb780#3594
Object of testing: #8564
Tier of Testing: 1
Date: 26/08/2024

Testing Process:

  1. Loaded into the A32NX at KASE
  2. Powered on Aircraft
  3. Selected different ranges and modes on ND

Negatives:
When Selecting the ARPT filter on the panel with the ND at Range 10 I noticed a "MAP PARTLY DISPLAYED" notification even though there were no airports nearby at 10nm, when there was one at 20nm, and two at 30nm.
This then proceeded to occur when VORD, and WPT were selected as well.
I was able to make the notification go away by filling out the FROM/TO information on the INIT A page.

Testing Results:
Not Passed

Conclusions:
The MAP PARTLY DISPLAYED message did not occur at any other airports. After testing at KASE I loaded into LAX and did not see this notification even on the ND with various ranges/modes.
Media:
image
image
image

@tylerclt
Copy link

tylerclt commented Aug 26, 2024 •
edited
Loading

Quality Assurance Trainee Report

Discord: Tylerb780#3594
Object of testing: #8564
Tier of Testing: 1
Date: 26/08/2024)

Testing Process:

  1. Loaded into the A32NX at KASE
  2. Powered on Aircraft
  3. Selected different ranges and modes on ND

Negatives:
Same as the previous test, see the last report for details

Testing Results:
Passed

Conclusions:
Same issue is found on master. Test Passed.

Media:
Refer to the last test report

@flogross89
Copy link
Contributor Author

Code review deferred, see issue #8843 --> Merged

@flogross89 flogross89 enabled auto-merge (squash) September 1, 2024 22:04
@flogross89 flogross89 merged commit 7fcdb55 into flybywiresim:master Sep 1, 2024
7 checks passed
@flogross89 flogross89 deleted the feat-a380x-oans branch October 12, 2024 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tracernz tracernz tracernz approved these changes

Assignees
No one assigned
Labels
Needs Code Review QA Passed
Projects
Quality Assurance
Status: ✔️ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.