feat(lnav): fa and fm legs #7324
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Which is correct though?
Previously we only showed one or the other, depending on whether TMPY existed
tracernz
commented
Jul 17, 2022
Comment on lines
+59
to
+80
| get mapSymbols(): GeometryNdSymbol[] { | ||
| const symbols = []; | ||
|
|
||
| const followingDiscont = !this.inboundGuidable; | ||
|
|
||
| if (followingDiscont) { | ||
| symbols.push({ | ||
| databaseId: this.fix.icao, | ||
| ident: this.fix.ident, | ||
| location: this.fix.infos.coordinates, | ||
| }); | ||
| } | ||
|
|
||
| symbols.push({ | ||
| databaseId: EfisSymbols.tempDatabaseId(this.ident), | ||
| ident: this.ident, | ||
| location: this.getPathEndPoint(), | ||
| speedConstraint: EfisSymbols.mapSpeedConstraintFromMetadata(this.metadata.speedConstraint), | ||
| }); | ||
|
|
||
| return symbols; | ||
| } |
There was a problem hiding this comment.
I don't like this... I think the discont logic + extra symbol can be figured out in the EfisSymbols logic..
|
I will keep this PR until after fms-v2 merges, then I can rework some of it's stuff on top. |
Benjozork
added
the
Waiting for PR merge
|
Waiting on #7692 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes LGSK SIDs (e.g. EVIKO1B) and LSZH SIDs (e.g. VEBI4S).
Summary of Changes
Refactor symbols to remove the remainder of the old flight plan based stuff, and allow legs to have more than one symbol (e.g. FA leg after discont).
Implement FA and FM legs.
Screenshots (if necessary)
EVIKO1B before:
EVIKO1B after (I have a patch for decel in a branch somewhere... 😨 #7333) :
References
Additional context
Discord username (if different from GitHub):
Testing instructions
How to download the PR for QA
Every new commit to this PR will cause a new A32NX artifact to be created, built, and uploaded.