Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FL-3920] Fix lost BadBLE keystrokes #3993

Open
wants to merge 8 commits into
base: dev
Choose a base branch
from
Open

[FL-3920] Fix lost BadBLE keystrokes #3993

wants to merge 8 commits into from
+48 −9

Conversation

Astrrra
Copy link
Member

@Astrrra Astrrra commented Nov 7, 2024 •
edited
Loading

What's new

  • BadBLE shouldn't drop keystrokes when log level is at Default or less

Verification

  • The changes in this PR cover commonly used BLE api methods, so all aspects of BLE communication should be tested, not only BadBLE

Checklist (For Reviewer)

  • PR has description of feature/bug or link to Confluence/Jira task
  • Description contains actions to verify feature/bugfix
  • I've built this code, uploaded it to the device and verified feature/bugfix

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 7, 2024 •
edited
Loading

Compiled f7 firmware for commit 2be7d3af:

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 7, 2024

PVS-Studio report for commit d660eb47:

@Astrrra Astrrra changed the title [FL-3920] WIP: fix lost BadBLE keystrokes [FL-3920] Fix lost BadBLE keystrokes Nov 26, 2024
@Astrrra Astrrra marked this pull request as ready for review November 26, 2024 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skotopes skotopes Awaiting requested review from skotopes skotopes is a code owner

@DrZlo13 DrZlo13 Awaiting requested review from DrZlo13 DrZlo13 is a code owner

@hedger hedger Awaiting requested review from hedger hedger is a code owner

@gsurkov gsurkov Awaiting requested review from gsurkov gsurkov is a code owner

@nminaylov nminaylov Awaiting requested review from nminaylov nminaylov is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Astrrra