Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add MutableOrientedHyperbolicSurface #243

Draft
wants to merge 71 commits into
base: master
Choose a base branch
from
Draft

Add MutableOrientedHyperbolicSurface #243

wants to merge 71 commits into from

Commits on Jul 5, 2023

  1. Add MutableOrientedHyperbolicSurface

    @saraedum
    saraedum committed Jul 5, 2023
    Configuration menu
    Copy the full SHA
    dc818e3 View commit details
    Browse the repository at this point in the history

Commits on Jul 7, 2023

  1. Merge remote-tracking branch 'origin/master' into hyperbolic_surface

    @saraedum
    saraedum committed Jul 7, 2023
    Configuration menu
    Copy the full SHA
    874e6ef View commit details
    Browse the repository at this point in the history

  2. Add basics for building hyperbolic surfaces

    @saraedum
    saraedum committed Jul 7, 2023
    Configuration menu
    Copy the full SHA
    ceed905 View commit details
    Browse the repository at this point in the history

  3. Add doctest output

    @saraedum
    saraedum committed Jul 7, 2023
    Configuration menu
    Copy the full SHA
    a907243 View commit details
    Browse the repository at this point in the history

  4. Make vertices() of hyperbolic polygons work

    @saraedum
    saraedum committed Jul 7, 2023
    Configuration menu
    Copy the full SHA
    27fe717 View commit details
    Browse the repository at this point in the history

  5. Add cusps() for hyperbolic surfaces

    @saraedum
    saraedum committed Jul 7, 2023
    Configuration menu
    Copy the full SHA
    0b54357 View commit details
    Browse the repository at this point in the history

Commits on Jul 10, 2023

  1. Document hyperbolic surface category

    @saraedum
    saraedum committed Jul 10, 2023
    Configuration menu
    Copy the full SHA
    ed66260 View commit details
    Browse the repository at this point in the history

  2. Implement plotting for hyperbolic surfaces 

    we are not doing any layouting here so the result is probably mostly
useless.
    @saraedum
    saraedum committed Jul 10, 2023
    Configuration menu
    Copy the full SHA
    a88f522 View commit details
    Browse the repository at this point in the history

Commits on Jul 18, 2023

  1. Normalize point coordinates 

    we need to make sure that point coordinates are hashable (for the
representatives set.) Also, it's probably helpful that all points have
the same structure (and not some are tuples say.)

If there's a performance impact, we might revisit the implementation
later but points are not used much currently anyway.
    @saraedum
    saraedum committed Jul 18, 2023
    Configuration menu
    Copy the full SHA
    433999d View commit details
    Browse the repository at this point in the history

  2. Revert "Normalize point coordinates" 

    This reverts commit 433999d.

We must not normalize points such as the ones that come from hyperbolic
points since there coordinates are not always available.
    @saraedum
    saraedum committed Jul 18, 2023
    Configuration menu
    Copy the full SHA
    be09c50 View commit details
    Browse the repository at this point in the history

  3. Fix some mutability issues to make hyperbolic surfaces work

    @saraedum
    saraedum committed Jul 18, 2023
    Configuration menu
    Copy the full SHA
    07f0342 View commit details
    Browse the repository at this point in the history

Commits on Jul 19, 2023

  1. Deprecate angles() in favor of angle()

    @saraedum
    saraedum committed Jul 19, 2023
    Configuration menu
    Copy the full SHA
    5adb70f View commit details
    Browse the repository at this point in the history

  2. Improve printing of hyperbolic surfaces

    @saraedum
    saraedum committed Jul 19, 2023
    Configuration menu
    Copy the full SHA
    ee12150 View commit details
    Browse the repository at this point in the history

Commits on Jul 20, 2023

  1. Fix computation of orbifold points

    @saraedum
    saraedum committed Jul 20, 2023
    Configuration menu
    Copy the full SHA
    046bfe7 View commit details
    Browse the repository at this point in the history

  2. Add rudimentary support for orbifold points

    @saraedum
    saraedum committed Jul 20, 2023
    Configuration menu
    Copy the full SHA
    d38abe8 View commit details
    Browse the repository at this point in the history

  3. Unify isometries and similarities acting on edges of polygons

    @saraedum
    saraedum committed Jul 20, 2023
    Configuration menu
    Copy the full SHA
    828f0a4 View commit details
    Browse the repository at this point in the history

  4. Improve doctesting of hyperbolic surfaces

    @saraedum
    saraedum committed Jul 20, 2023
    Configuration menu
    Copy the full SHA
    6e1db82 View commit details
    Browse the repository at this point in the history

  5. Fix printing of polygons making up surfaces

    @saraedum
    saraedum committed Jul 20, 2023
    Configuration menu
    Copy the full SHA
    c0e8c50 View commit details
    Browse the repository at this point in the history

Commits on Jul 21, 2023

  1. Remove duplicated doctests

    @saraedum
    saraedum committed Jul 21, 2023
    Configuration menu
    Copy the full SHA
    cf07ac1 View commit details
    Browse the repository at this point in the history

  2. Document angle() of cone surfaces

    @saraedum
    saraedum committed Jul 21, 2023
    Configuration menu
    Copy the full SHA
    7bda80f View commit details
    Browse the repository at this point in the history

  3. Document is_right() and is_isosceles()

    @saraedum
    saraedum committed Jul 21, 2023
    Configuration menu
    Copy the full SHA
    18db2e7 View commit details
    Browse the repository at this point in the history

  4. Document changes in get_edge()

    @saraedum
    saraedum committed Jul 21, 2023
    Configuration menu
    Copy the full SHA
    978ac18 View commit details
    Browse the repository at this point in the history

  5. Improve error message

    @saraedum
    saraedum committed Jul 21, 2023
    Configuration menu
    Copy the full SHA
    6235123 View commit details
    Browse the repository at this point in the history

  6. Document angle() for half translation surfaces

    @saraedum
    saraedum committed Jul 21, 2023
    Configuration menu
    Copy the full SHA
    a15e020 View commit details
    Browse the repository at this point in the history

Commits on Jul 27, 2023

  1. Improve printing of hyperbolic surfaces with boundary

    @saraedum
    saraedum committed Jul 27, 2023
    Configuration menu
    Copy the full SHA
    16792c7 View commit details
    Browse the repository at this point in the history

  2. Fix midpoint containment computations

    @saraedum
    saraedum committed Jul 27, 2023
    Configuration menu
    Copy the full SHA
    64821ff View commit details
    Browse the repository at this point in the history

  3. Fix infinite recursion in printing of midpoints

    @saraedum
    saraedum committed Jul 27, 2023
    Configuration menu
    Copy the full SHA
    ca17da9 View commit details
    Browse the repository at this point in the history

  4. Improve printing of hyperbolic midpoints

    @saraedum
    saraedum committed Jul 27, 2023
    Configuration menu
    Copy the full SHA
    55e9c40 View commit details
    Browse the repository at this point in the history

  5. Allow gluing of half-infinite hyperbolic edges

    @saraedum
    saraedum committed Jul 27, 2023
    Configuration menu
    Copy the full SHA
    3f4c82e View commit details
    Browse the repository at this point in the history

  6. Fix & document implementation of cusps and orbifold points

    @saraedum
    saraedum committed Jul 27, 2023
    Configuration menu
    Copy the full SHA
    0690cca View commit details
    Browse the repository at this point in the history

  7. Add angle() method to surface points

    @saraedum
    saraedum committed Jul 27, 2023
    Configuration menu
    Copy the full SHA
    69ecf78 View commit details
    Browse the repository at this point in the history

  8. Document ElementMethods container

    @saraedum
    saraedum committed Jul 27, 2023
    Configuration menu
    Copy the full SHA
    62ff3a8 View commit details
    Browse the repository at this point in the history

  9. Document new methods for hyperbolic isometry surfaces

    @saraedum
    saraedum committed Jul 27, 2023
    Configuration menu
    Copy the full SHA
    94d1401 View commit details
    Browse the repository at this point in the history

Commits on Jul 30, 2023

  1. Implement adjacencies() for polygons

    @saraedum
    saraedum committed Jul 30, 2023
    Configuration menu
    Copy the full SHA
    ea18bc0 View commit details
    Browse the repository at this point in the history

Commits on Jul 31, 2023

  1. Improve printing of hyperbolic segments

    @saraedum
    saraedum committed Jul 31, 2023
    Configuration menu
    Copy the full SHA
    1f62768 View commit details
    Browse the repository at this point in the history

  2. Fix midpoint computation when defined over the base ring

    @saraedum
    saraedum committed Jul 31, 2023
    Configuration menu
    Copy the full SHA
    715c8a6 View commit details
    Browse the repository at this point in the history

Commits on Aug 17, 2023

  1. Fix doctests

    @saraedum
    saraedum committed Aug 17, 2023
    Configuration menu
    Copy the full SHA
    06859ee View commit details
    Browse the repository at this point in the history

  2. Fix spacing

    @saraedum
    saraedum committed Aug 17, 2023
    Configuration menu
    Copy the full SHA
    4e17413 View commit details
    Browse the repository at this point in the history

  3. Deduplicate plot() function of surfaces

    @saraedum
    saraedum committed Aug 17, 2023
    Configuration menu
    Copy the full SHA
    1d11bef View commit details
    Browse the repository at this point in the history

Commits on Aug 23, 2023

  1. Add news

    @saraedum
    saraedum committed Aug 23, 2023
    Configuration menu
    Copy the full SHA
    b3b4baf View commit details
    Browse the repository at this point in the history

Commits on Aug 24, 2023

  1. Remove unused imports

    @saraedum
    saraedum committed Aug 24, 2023
    Configuration menu
    Copy the full SHA
    d8efcb4 View commit details
    Browse the repository at this point in the history

  2. Fix polygon plot in hyperbolic surfaces

    @saraedum
    saraedum committed Aug 24, 2023
    Configuration menu
    Copy the full SHA
    4019ab1 View commit details
    Browse the repository at this point in the history

  3. Refer to notebook of examples for plotting documentation 

    since the reference manual does not contain any pictures, providing good
examples there is a bit useless.
    @saraedum
    saraedum committed Aug 24, 2023
    Configuration menu
    Copy the full SHA
    3c96335 View commit details
    Browse the repository at this point in the history

Commits on Aug 25, 2023

  1. Improve fill of polygons 

    I heard complaints about the grey being not very pretty so let's make it
almost white.
    @saraedum
    saraedum committed Aug 25, 2023
    Configuration menu
    Copy the full SHA
    40cfe14 View commit details
    Browse the repository at this point in the history

Commits on Sep 12, 2023

  1. Implement layout(algorithm="trajectory")

    @saraedum
    saraedum committed Sep 12, 2023
    Configuration menu
    Copy the full SHA
    5de31ec View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'origin/master' into hyperbolic_surface

    @saraedum
    saraedum committed Sep 12, 2023
    Configuration menu
    Copy the full SHA
    5340849 View commit details
    Browse the repository at this point in the history

Commits on Sep 17, 2023

  1. Turn longstanding TODOs into NOTEs

    @saraedum
    saraedum committed Sep 17, 2023
    Configuration menu
    Copy the full SHA
    fd01b41 View commit details
    Browse the repository at this point in the history

  2. Turn TODOs into NotImplementedErrors for polygons

    @saraedum
    saraedum committed Sep 17, 2023
    Configuration menu
    Copy the full SHA
    f7bd8f6 View commit details
    Browse the repository at this point in the history

  3. Drop TODO 

    the algorithm is probably not successful because the order is not finite
in that case but that should have failed before already.
    @saraedum
    saraedum committed Sep 17, 2023
    Configuration menu
    Copy the full SHA
    3b514f7 View commit details
    Browse the repository at this point in the history

  4. is_right_triangle() for hyperbolic triangles

    @saraedum
    saraedum committed Sep 17, 2023
    Configuration menu
    Copy the full SHA
    c945e4e View commit details
    Browse the repository at this point in the history

  5. Implement is_isosceles_triangle() for hyperbolic triangles

    @saraedum
    saraedum committed Sep 17, 2023
    Configuration menu
    Copy the full SHA
    28c3dd4 View commit details
    Browse the repository at this point in the history

  6. Implement is_equilateral() for hyperbolic polygons

    @saraedum
    saraedum committed Sep 17, 2023
    Configuration menu
    Copy the full SHA
    26f3dcd View commit details
    Browse the repository at this point in the history

  7. Implement is_equiangular() for hyperbolic polygons

    @saraedum
    saraedum committed Sep 17, 2023
    Configuration menu
    Copy the full SHA
    5753cc7 View commit details
    Browse the repository at this point in the history

  8. Fix doctest

    @saraedum
    saraedum committed Sep 17, 2023
    Configuration menu
    Copy the full SHA
    f291724 View commit details
    Browse the repository at this point in the history

  9. Clarify isometry condition

    @saraedum
    saraedum committed Sep 17, 2023
    Configuration menu
    Copy the full SHA
    f7e07cb View commit details
    Browse the repository at this point in the history

  10. Deduplicate midpoint computations

    @saraedum
    saraedum committed Sep 17, 2023
    Configuration menu
    Copy the full SHA
    8405663 View commit details
    Browse the repository at this point in the history

Commits on Sep 18, 2023

  1. Fix handling of unoriented geodesics and segments

    @saraedum
    saraedum committed Sep 18, 2023
    Configuration menu
    Copy the full SHA
    7d31e4f View commit details
    Browse the repository at this point in the history

  2. Deprecate coordinates() which does not easily make sense in the hyper… 

    …bolic case
    @saraedum
    saraedum committed Sep 18, 2023
    Configuration menu
    Copy the full SHA
    5da9f28 View commit details
    Browse the repository at this point in the history

  3. Turn longstanding TODO into a Note

    @saraedum
    saraedum committed Sep 18, 2023
    Configuration menu
    Copy the full SHA
    1b0c62c View commit details
    Browse the repository at this point in the history

  4. Simplify alignment logic

    @saraedum
    saraedum committed Sep 18, 2023
    Configuration menu
    Copy the full SHA
    3bfa0ef View commit details
    Browse the repository at this point in the history

  5. Mark TODOs as resolved

    @saraedum
    saraedum committed Sep 18, 2023
    Configuration menu
    Copy the full SHA
    39d4ac7 View commit details
    Browse the repository at this point in the history

  6. Resolve TODO

    @saraedum
    saraedum committed Sep 18, 2023
    Configuration menu
    Copy the full SHA
    66ab592 View commit details
    Browse the repository at this point in the history

  7. Resolve TODO 

    and revert equality of ordered sets without further assumptions on the
data.
    @saraedum
    saraedum committed Sep 18, 2023
    Configuration menu
    Copy the full SHA
    46cb86a View commit details
    Browse the repository at this point in the history

  8. Resolve TODO

    @saraedum
    saraedum committed Sep 18, 2023
    Configuration menu
    Copy the full SHA
    b5620d8 View commit details
    Browse the repository at this point in the history

  9. Remove incorrect hash function

    @saraedum
    saraedum committed Sep 18, 2023
    Configuration menu
    Copy the full SHA
    e153135 View commit details
    Browse the repository at this point in the history

  10. Fix representative() implementation

    @saraedum
    saraedum committed Sep 18, 2023
    Configuration menu
    Copy the full SHA
    1313bda View commit details
    Browse the repository at this point in the history

  11. Fix deprecation warnings

    @saraedum
    saraedum committed Sep 18, 2023
    Configuration menu
    Copy the full SHA
    e1f7af2 View commit details
    Browse the repository at this point in the history

  12. Remove resolved TODO

    @saraedum
    saraedum committed Sep 18, 2023
    Configuration menu
    Copy the full SHA
    f482511 View commit details
    Browse the repository at this point in the history

  13. Turn an old TODO into a Note

    @saraedum
    saraedum committed Sep 18, 2023
    Configuration menu
    Copy the full SHA
    ec3e802 View commit details
    Browse the repository at this point in the history

  14. Remove leftovers from the old graphical surface implementation

    @saraedum
    saraedum committed Sep 18, 2023
    Configuration menu
    Copy the full SHA
    79c0be5 View commit details
    Browse the repository at this point in the history

  15. Implement most of hyperbolic surface plotting

    @saraedum
    saraedum committed Sep 18, 2023
    Configuration menu
    Copy the full SHA
    8ef5c10 View commit details
    Browse the repository at this point in the history