Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

monotile notebook #238

Open
wants to merge 11 commits into
base: master
Choose a base branch
from
Open

monotile notebook #238

wants to merge 11 commits into from

Conversation

videlec
Copy link
Collaborator

@videlec videlec commented Jun 27, 2023

Add a notebook for playing with the monotile (a non-convex polygon tiling the plane)

Checklist

  • Added an entry in doc/news/
  • Added a test for this change : irrelevant
  • Added new .py files to the documentation in doc/geometry or doc/graphical : irrelevant

Failures to be fixed in other PR

doc/examples/monotile.md Outdated Show resolved Hide resolved
doc/examples/monotile.md Outdated Show resolved Hide resolved
@videlec
Copy link
Collaborator Author

videlec commented Jun 27, 2023

I think that some of the logic in the notebook should be converted in a "translation surface wizard".

doc/examples/monotile.md Outdated Show resolved Hide resolved
doc/news/monotile.rst Outdated Show resolved Hide resolved
@saraedum
Copy link
Member

I think that some of the logic in the notebook should be converted in a "translation surface wizard".

Yes. It's somewhat tedious to do all this without a wizard.

@saraedum
Copy link
Member

saraedum commented Jun 27, 2023

@videlec you need to add the notebook to the documentation in the examples section btw.

videlec and others added 3 commits June 28, 2023 07:51
- improve the notebook
- add it in the documentation index
Copy link
Member

@saraedum saraedum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. The notebook ends without any conclusion of sorts but I think this can be merged.

Comment on lines +121 to +128

```{code-cell}
S1.triangulate()
```

```{code-cell}
S2.triangulate()
```
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you want to comment on these or just leave them like this?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you want to comment on these or just leave them like this?

For now I just want to play with the surface to test what works and what does not work. I would prefer #93 to be solved first.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ideally, I would also like to visualize the plane tiling using rotation/reflection of the tile.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ideally, I would also like to visualize the plane tiling using rotation/reflection of the tile.

It would not be hard to extend hyperbolic tessellations to tilings of the plane.

@github-actions
Copy link

github-actions bot commented Jul 4, 2023

Documentation preview for this PR is ready! 🎉
Built with commit: 003c1b9

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants