-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add deformations and treat pyflatsurf surfaces like native surfaces #211
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here we bring a system like the libflatsurf
Deformation
maps to sage-flatsurf. The idea is that this allows us to map all kinds of objects between surfaces that are related to each other.To make this fully functional, all operations that modify a surface need to produce a
Deformation
instead that can (sometimes) be used to map objects.In particular this will allow us to understand whether subdivision for harmonic differentials actually converge correctly (currently, it's extremely annoying to relate a point on the surface before and after subdivision and retriangulation.)
At the same time, we introduce
Surface_pyflatsurf
which provides a pyflatsurfFlatTriangulation
with the sage-flatsurfSurface
interface. In particular, a libflatsurfDeformation
then can be naturally turned into aDeformation_pyflatsurf
to map sage-flatsurf objects across it.Checklist
doc/news/
.doc/geometry
ordoc/graphical
.TestSuite
runs for all new objects.