Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add deformations and treat pyflatsurf surfaces like native surfaces #211

Closed
wants to merge 176 commits into from

Conversation

saraedum
Copy link
Member

@saraedum saraedum commented Mar 22, 2023

Here we bring a system like the libflatsurf Deformation maps to sage-flatsurf. The idea is that this allows us to map all kinds of objects between surfaces that are related to each other.

To make this fully functional, all operations that modify a surface need to produce a Deformation instead that can (sometimes) be used to map objects.

In particular this will allow us to understand whether subdivision for harmonic differentials actually converge correctly (currently, it's extremely annoying to relate a point on the surface before and after subdivision and retriangulation.)

At the same time, we introduce Surface_pyflatsurf which provides a pyflatsurf FlatTriangulation with the sage-flatsurf Surface interface. In particular, a libflatsurf Deformation then can be naturally turned into a Deformation_pyflatsurf to map sage-flatsurf objects across it.

Checklist

  • Added an entry in doc/news/.
  • Added a test for this change.
  • Added new .py files to the documentation in doc/geometry or doc/graphical.
  • Ensure that TestSuite runs for all new objects.

@saraedum

This comment was marked as outdated.

@saraedum saraedum mentioned this pull request Mar 22, 2023
5 tasks
@saraedum saraedum mentioned this pull request Aug 10, 2024
3 tasks
@saraedum
Copy link
Member Author

saraedum commented Aug 26, 2024

This won't be merged as is. We need to cherry-pick small bits out of it as we did in #295. We'll use #213 as a base to cherry-pick from into smaller PRs.

@saraedum saraedum closed this Aug 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants