-
-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: migrate to GitHub Container Registry #82
Conversation
I believe this is all correct. Note that the Flatpak Builder test can't succeed until the PR is actually merged, because the images aren't available until after (See: successful test in my fork). The worflows use |
28faabe
to
4d641e9
Compare
4d641e9
to
c2d42ea
Compare
So before we actually land this one, I think we should ship one single image that provides the basic tools to build/deploy a flatpak application without any pre-configured remotes. Then flathub could provide a set of images itself that contains the various SDKs combinations that would be built on top of the basic image provided by the actions itself. We would still document the availabilities of such images in the readme as well as keep the current images up to date for a while, so I would add a new job instead of modifying current ones. As we moved to the flatpak namespace, i want to keep it clear that flatpak is not tied to flathub and can be used with other remotes if desired. |
So I guess what you mean is more or less the FROM registry.fedoraproject.org/fedora:latest
RUN dnf update -y && \
dnf install -y flatpak flatpak-builder python3-aiohttp python3-tenacity python3-gobject xorg-x11-server-Xvfb ccache zstd && \
dnf clean all
ADD https://raw.githubusercontent.com/flatpak/flat-manager/master/flat-manager-client /usr/bin
RUN chmod +x /usr/bin/flat-manager-client If so, I can open a PR with a new |
In some cases the docker.io source lags behind upstream, so be explicit about where the image should come from.
* bump `docker/build-push-action` to v3 * bump `docker/login-action` to v2 * bump `docker/setup-buildx-action` to v2 * bump `docker/setup-qemu-action` to v2
Migrate the container images from DockerHub to GitHub's container registry. fixes flatpak#60
c2d42ea
to
afb0226
Compare
Okay, closing this one in favour of #101. |
Migrate the container images from DockerHub to GitHub's container
registry.
This pull request also bumps the related Docker GitHub Actions and
makes the source of Fedora's base image explicit.
fixes #60