flatpak-builder: add configuration option for local repository path #141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -9,7 +9,7 @@ class Configuration { | |||
| this.endOfLife = core.getInput('end-of-life') | |||
| this.endOfLifeRebase = core.getInput('end-of-life-rebase') | |||
| // FIXME: get this from the outputs of the flatpak-builder action | |||
| this.localRepoName = 'repo' | |||
| this.localRepoPath = 'repo' | |||
There was a problem hiding this comment.
you probably want
Suggested change
| this.localRepoPath = 'repo' | |
| this.localRepoPath = core.getInput('local-repository') || 'repo' |
There was a problem hiding this comment.
I would also check if the path exists and is a directory otherwise error out early
| @@ -56,6 +56,7 @@ jobs: | |||
| | `arch` | Specifies the CPU architecture to build for | Optional | `x86_64` | | |||
| | `mirror-screenshots-url` | Specifies the URL to mirror screenshots | Optional | - | | |||
| | `gpg-sign` | The key to sign the package | Optional | - | | |||
| | `local-repository` | The path to the local OSTree repository used to export the built artifacts to and build the bundle from. If the path exists, it must point to a valid OSTree repository, otherwise a new repository will be created. | Optional | `repo` | | |||
There was a problem hiding this comment.
Please add the same for flat-manager + update the action.yml of flat-manager as well.
| @@ -9,7 +9,7 @@ class Configuration { | |||
| this.endOfLife = core.getInput('end-of-life') | |||
| this.endOfLifeRebase = core.getInput('end-of-life-rebase') | |||
| // FIXME: get this from the outputs of the flatpak-builder action | |||
There was a problem hiding this comment.
Would you mind also looking at the fixme above? =)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enables the user to configure the local repository path/name for
flatpak-builderinstead of hard-coding it asrepo. This is useful actions workflows that directly export artifacts into a separate, local repository, see for example here. I've renamedlocalRepoNametolocalRepoPathinflat-manageras well for consistency and since it should be a real filesystem path, but don't have enough context on how to best solve the FIXME in there.