Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add gpt-4o model support #2

Merged
merged 5 commits into from
Jul 30, 2024
Merged

Add gpt-4o model support #2

merged 5 commits into from
Jul 30, 2024

Conversation

juberti
Copy link

@juberti juberti commented Jul 29, 2024

Taken from PR openai#1530

@juberti juberti requested a review from farzadab July 29, 2024 02:02
Copy link

@farzadab farzadab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@@ -23,6 +23,7 @@ def zero_if_none(input_num):
"cot/gpt-3.5-turbo",
"gpt-3.5-turbo",
"gpt-4-base",
"gpt-4o",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: 4o-mini instead of 4o maybe to reduce the costs?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll do a followup to add mini too, and send it upstream as well

@juberti juberti merged commit 8f7790b into main Jul 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants