-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Readd portable Electrum for Windows #70
Conversation
WalkthroughThe recent updates to the GitHub Actions workflow enhance the build process for the Firo-Electrum project. A new step has been introduced to rename the executable file, improving its branding clarity. Additionally, the artifact upload path has been adjusted to include the renamed file, ensuring it's properly accessible post-build. These changes streamline artifact organization and improve user experience after releases. Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- .github/workflows/build_release.yml (2 hunks)
Additional comments not posted (2)
.github/workflows/build_release.yml (2)
72-73
: LGTM! Adding a step to rename the portable binary improves clarity.This step ensures that the portable executable is clearly named, aligning with the project's branding.
82-82
: LGTM! Updating the artifact upload path ensures the renamed portable executable is included.This change ensures that the renamed portable executable is properly included in the release artifacts.
Portable Electrum was removed when we switched to Github Actions some time ago. This PR reintroduces it so it can be included in our releases.
Summary by CodeRabbit
New Features
Chores