Fix #if in AnalogOutputFirmata.h
#174
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `void internalReset();` private member function of the AnalogOutputFirmata class is intended to only be defined if compiling on ESP32. No other code in this library uses `#if ESP32`, they all use `#ifdef ESP32`. When changing this to use `#ifdef`, this successfully compiles in Arduino IDE 2.3.2. Previously, when using `#if`, this wasn't compiling and the compiler complained about there being no member function defined for the class. Hopefully this works in other situations and doesn't break anything else.
|
Thanks a lot for the suggested fix. Coincidentaly, a similar patch for this issue already had a PR open at #170 which is now merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
void internalReset();private member function of the AnalogOutputFirmata class is intended to only be defined if compiling on ESP32.No other code in this library uses
#if ESP32, they all use#ifdef ESP32. When changing this to use#ifdef, this successfully compiles in Arduino IDE 2.3.2. Previously, when using#if, this wasn't compiling and the compiler complained about there being no member function defined for the class.Hopefully this works in other situations and doesn't break anything else.