Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use raise ... from ... idiom #686

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

soof-golan
Copy link

Hey firebase team 👋

Please consider merging this to improve the debugging experience by chaining errors in a pythonic way.

This yields better stacktraces in case something goes south.

Please note: I've add these raise ... from ... statements only where the new exception already references to original error in some as a measure of not leaking information that you might want to keep confidential.

Fixes #685

Hey there! So you want to contribute to a Firebase SDK?
Before you file this pull request, please read these guidelines:

Discussion

  • Read the contribution guidelines (CONTRIBUTING.md).
  • If this has been discussed in an issue, make sure to link to the issue here.
    If not, go file an issue about this before creating a pull request to discuss.

Testing

  • Make sure all existing tests in the repository pass after your change.
  • If you fixed a bug or added a feature, add a new test to cover your code.

API Changes

  • At this time we cannot accept changes that affect the public API. If you'd like to help
    us make Firebase APIs better, please propose your change in an issue so that we
    can discuss it together.

Improve debugging by chaining the error cause in a pythonic way.
@lahirumaramba lahirumaramba self-requested a review March 30, 2023 21:03
@lahirumaramba lahirumaramba self-assigned this Mar 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FR] using raise ... from ... to improve sdk debugging
2 participants