Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make getLocaleLabelUsing usable in service provider #22

Open
wants to merge 1 commit into
base: 3.x
Choose a base branch
from

Conversation

johanmolen
Copy link

@johanmolen johanmolen commented Nov 27, 2024

Right now we can not do the following within the panel service providers:

    public function panel(Panel $panel): Panel
    {
        return $panel
            ->plugins([
                SpatieLaravelTranslatablePlugin::make()
                    ->defaultLocales(
                        array_map(
                            static fn ($locale) => type($locale)->asString(),
                            config()->array('app.locales')
                        )
                    )
                    ->getLocaleLabelUsing(fn (string $locale, ?string $displayLocale = null): ?string => $locale),
            ])
    }

Because getLocaleLabelUsing is not returning the plugin itself, which is expected by the panel plugins() method.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant