Skip to content

Commit

Permalink
Update rubocop.
Browse files Browse the repository at this point in the history
  • Loading branch information
arscan committed Apr 23, 2019
1 parent 2067f2f commit a9e3e7a
Show file tree
Hide file tree
Showing 2 changed files with 84 additions and 36 deletions.
118 changes: 83 additions & 35 deletions .rubocop_todo.yml
Original file line number Diff line number Diff line change
@@ -1,62 +1,108 @@
# This configuration was generated by
# `rubocop --auto-gen-config`
# on 2019-03-22 01:48:08 -0400 using RuboCop version 0.52.1.
# on 2019-04-22 22:05:37 -0400 using RuboCop version 0.67.2.
# The point is for the user to remove these configuration records
# one by one as the offenses are removed from the code base.
# Note that changes in the inspected code, or installation of new
# versions of RuboCop, may require this file to be generated again.

# Offense count: 39
# Offense count: 51
# Cop supports --auto-correct.
Layout/EmptyLineAfterGuardClause:
Exclude:
- 'lib/fhir_models/bootstrap/definitions.rb'
- 'lib/fhir_models/bootstrap/generator.rb'
- 'lib/fhir_models/bootstrap/hashable.rb'
- 'lib/fhir_models/bootstrap/model.rb'
- 'lib/fhir_models/bootstrap/preprocess.rb'
- 'lib/fhir_models/bootstrap/xml.rb'
- 'lib/fhir_models/deprecate.rb'
- 'lib/fhir_models/fhir_ext/element_definition.rb'
- 'lib/fhir_models/fhir_ext/structure_definition.rb'
- 'lib/fhir_models/fhir_ext/structure_definition_compare.rb'
- 'lib/fhir_models/fluentpath/parse.rb'

# Offense count: 1
# Cop supports --auto-correct.
Layout/RescueEnsureAlignment:
Exclude:
- 'lib/fhir_models/bootstrap/hashable.rb'

# Offense count: 2
# Cop supports --auto-correct.
Lint/ToJSON:
Exclude:
- 'lib/fhir_models/bootstrap/json.rb'
- 'lib/fhir_models/fhir_ext/structure_definition_finding.rb'

# Offense count: 40
Metrics/AbcSize:
Max: 423
Max: 392

# Offense count: 7
# Configuration parameters: CountComments, ExcludedMethods.
# ExcludedMethods: refine
Metrics/BlockLength:
Max: 100
Max: 74

# Offense count: 7
# Offense count: 8
# Configuration parameters: CountBlocks.
Metrics/BlockNesting:
Max: 5

# Offense count: 6
# Offense count: 7
# Configuration parameters: CountComments.
Metrics/ClassLength:
Max: 500
Max: 354

# Offense count: 25
# Offense count: 23
Metrics/CyclomaticComplexity:
Max: 69
Max: 65

# Offense count: 43
# Configuration parameters: CountComments.
# Offense count: 44
# Configuration parameters: CountComments, ExcludedMethods.
Metrics/MethodLength:
Max: 200
Max: 131

# Offense count: 1
# Offense count: 2
# Configuration parameters: CountComments.
Metrics/ModuleLength:
Max: 114

# Offense count: 24
# Offense count: 23
Metrics/PerceivedComplexity:
Max: 72
Max: 68

# Offense count: 1
# Configuration parameters: PreferredName.
Naming/RescuedExceptionsVariableName:
Exclude:
- 'lib/fhir_models/bootstrap/hashable.rb'

# Offense count: 4
# Configuration parameters: MinNameLength, AllowNamesEndingInNumbers, AllowedNames, ForbiddenNames.
# AllowedNames: io, id, to, by, on, in, at, ip, db
Naming/UncommunicativeMethodParamName:
Exclude:
- 'lib/fhir_models/fhir_ext/structure_definition_compare.rb'

# Offense count: 3
Performance/Caller:
Exclude:
- 'lib/fhir_models/bootstrap/model.rb'
- 'lib/fhir_models/deprecate.rb'

# Offense count: 3
# Offense count: 1
# Cop supports --auto-correct.
# Configuration parameters: AutoCorrect.
Performance/HashEachMethods:
Performance/InefficientHashSearch:
Exclude:
- 'lib/fhir_models/bootstrap/definitions.rb'
- 'lib/fhir_models/bootstrap/model.rb'
- 'lib/fhir_models/bootstrap/preprocess.rb'
- 'lib/fhir_models/bootstrap/template.rb'

# Offense count: 1
# Configuration parameters: .
# SupportedStyles: inline, group
Style/AccessModifierDeclarations:
EnforcedStyle: inline

# Offense count: 17
Style/ClassVars:
Expand Down Expand Up @@ -90,7 +136,7 @@ Style/Documentation:
- 'lib/fhir_models/fluentpath/expression.rb'
- 'lib/fhir_models/fluentpath/parse.rb'

# Offense count: 28
# Offense count: 29
# Cop supports --auto-correct.
Style/IfUnlessModifier:
Exclude:
Expand All @@ -103,27 +149,33 @@ Style/IfUnlessModifier:
- 'lib/fhir_models/fhir_ext/structure_definition_compare.rb'

# Offense count: 1
Style/MethodMissing:
Style/MethodMissingSuper:
Exclude:
- 'lib/fhir_models/bootstrap/model.rb'

# Offense count: 6
# Offense count: 1
Style/MissingRespondToMissing:
Exclude:
- 'lib/fhir_models/bootstrap/model.rb'

# Offense count: 9
Style/MultipleComparison:
Exclude:
- 'lib/fhir_models/bootstrap/definitions.rb'
- 'lib/fhir_models/bootstrap/generator.rb'
- 'lib/fhir_models/bootstrap/model.rb'
- 'lib/fhir_models/fhir_ext/structure_definition.rb'

# Offense count: 2
# Cop supports --auto-correct.
# Configuration parameters: AutoCorrect, EnforcedStyle.
# Configuration parameters: AutoCorrect, EnforcedStyle, IgnoredMethods.
# SupportedStyles: predicate, comparison
Style/NumericPredicate:
Exclude:
- 'spec/**/*'
- 'lib/fhir_models/fhir_ext/structure_definition_compare.rb'

# Offense count: 1
# Offense count: 2
# Cop supports --auto-correct.
Style/OrAssignment:
Exclude:
Expand All @@ -146,25 +198,21 @@ Style/RescueStandardError:
- 'lib/fhir_models/fluentpath/expression.rb'
- 'lib/fhir_models/fluentpath/parse.rb'

# Offense count: 4
# Offense count: 6
# Cop supports --auto-correct.
# Configuration parameters: ConvertCodeThatCanStartToReturnNil.
# Configuration parameters: ConvertCodeThatCanStartToReturnNil, Whitelist.
# Whitelist: present?, blank?, presence, try, try!
Style/SafeNavigation:
Exclude:
- 'lib/fhir_models/bootstrap/definitions.rb'
- 'lib/fhir_models/bootstrap/xml.rb'
- 'lib/fhir_models/fhir_ext/structure_definition.rb'

# Offense count: 7
# Cop supports --auto-correct.
# Configuration parameters: EnforcedStyle.
# SupportedStyles: all_comparison_operators, equality_operators_only
# SupportedStyles: forbid_for_all_comparison_operators, forbid_for_equality_operators_only, require_for_all_comparison_operators, require_for_equality_operators_only
Style/YodaCondition:
Exclude:
- 'lib/fhir_models/bootstrap/preprocess.rb'
- 'lib/fhir_models/fluentpath/parse.rb'

# Offense count: 270
# Configuration parameters: AllowHeredoc, AllowURI, URISchemes, IgnoreCopDirectives, IgnoredPatterns.
# URISchemes: http, https
Metrics/LineLength:
Max: 290
2 changes: 1 addition & 1 deletion fhir_models.gemspec
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ Gem::Specification.new do |spec|
spec.add_development_dependency 'rspec'
spec.add_development_dependency 'simplecov'
spec.add_development_dependency 'nokogiri-diff'
spec.add_development_dependency 'rubocop', '0.52.1'
spec.add_development_dependency 'rubocop', '0.67'
spec.add_development_dependency 'codeclimate-test-reporter'
spec.add_development_dependency 'guard-rspec'
spec.add_development_dependency 'guard-test'
Expand Down

0 comments on commit a9e3e7a

Please sign in to comment.