update nginx file to remove ruby erb #217
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
This ticket updates the nginx.conf file to remove ruby erb which is not supported in cflinuxfs4 according to this PR. This resolves the pathing/ frame element issues from removing the nginx.conf file.
Using our own nginx.conf file with static-buildpack gives us a warning that it is not recommend. We are using our own nginx file to support the frame elements. Eventually we should move over to the nginx-buildpack or remove all of the frame elements. Here is a previous discussion on this topic. I also created a ticket for this issue.
I tested this by deploying this test branch.