Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DRAFT] Links and metadata for single doc pages #5922

Draft
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

johnnyporkchops
Copy link
Contributor

Summary (required)

Required reviewers

one content, one UX

Impacted areas of the application

standalone document pages used to populate the feed

Screenshots


Link from title:

doc_title_linked


Link from document type:

file_extension_linked2


Also can link the category button to filtered parent:

Example: /about/reports-about-fec/oig-reports/?category=inspection+or+special+review+report&year=2023

link_category_btn


How to test

  • Remove dev deploy task before merge

Content/UX :
I can push to dev for testing once PR #5908 is merged

Devs:

  • Checkout and run branch
  • In Wagtail go to Pages > Home >About > Reports about the FEC > Choose one of the categories
  • View pages live to test the link to document on the title and the docuement-type
  • Test that the Category button above the title goes to a filtered page for that report-type/category/year

System architecture updates (if applicable)

(If this pull request changes our current system diagram, include a description of those changes here and create a new ticket to update the system diagram)

@johnnyporkchops johnnyporkchops removed the request for review from dorothyyeager September 22, 2023 04:57
@johnnyporkchops johnnyporkchops changed the title Links and metadata for single doc pages [WIP] Links and metadata for single doc pages Sep 22, 2023
@johnnyporkchops johnnyporkchops marked this pull request as draft September 22, 2023 14:33
@johnnyporkchops johnnyporkchops changed the title [WIP] Links and metadata for single doc pages [DRAFT] Links and metadata for single doc pages Sep 22, 2023
@codecov
Copy link

codecov bot commented Sep 28, 2023

Codecov Report

Merging #5922 (9326235) into develop (dfca860) will decrease coverage by 0.03%.
Report is 9 commits behind head on develop.
The diff coverage is 33.33%.

@@             Coverage Diff             @@
##           develop    #5922      +/-   ##
===========================================
- Coverage    78.37%   78.35%   -0.03%     
===========================================
  Files          288      288              
  Lines         9378     9383       +5     
  Branches       653      653              
===========================================
+ Hits          7350     7352       +2     
- Misses        2028     2031       +3     
Files Coverage Δ
fec/home/models.py 88.09% <0.00%> (-0.20%) ⬇️
fec/home/templatetags/filters.py 72.27% <50.00%> (-0.92%) ⬇️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wagtail Bug: Document Page template pages are showing up in search results
1 participant