-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DO NOT MERGE] Contact / Help App #5649
base: develop
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rfultz Really great work on this contact app so far. I have a few things that I noticed during my QA.
<div | ||
@click="handleButtonClick(item.actionId, $event)" | ||
class="card card--neutral"> | ||
<div class="card__image__container"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since the card isn't wrapped in an anchor, I think we lost the cursor:pointer
effect. It's helpful to have them so that users know they can click on the cards.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will be part of the next push
headline: 'Unable to send your message at this time.', | ||
message: `<strong>Submitting your message has failed.</strong> You’re welcome to try again, call the FEC offices, | ||
or use the content below to send your message through another platform.<br><br> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wondering if we should add phone number to the failure message and perhaps the success message as well? The reason is because we specifically give the option for the user to call if they want. Having the number readily available with their email would help them so they wouldn't have to go back through the form to retrieve it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That makes sense
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good call! The failure handler and response was just me throwing something together. I wonder how much it hurt UX and Content :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are we comfortable with the phone number that remains on the page? Or still add it into the success/failure message to a specific office?
congress: { | ||
name: 'Congressional Affairs', | ||
summary: 'Congressional Affairs responds to inquiries from other agencies and Congressional representatives', | ||
formPrompt: 'Contact Congressional Affairs via telephone.', | ||
phoneExt: '1006', | ||
ePrefix: 'congress', | ||
fields: '' | ||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good find! I knew I needed to hide the recaptcha (currently the testing radios) there but hiding submit is a good call. I think it should be the Start over button
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would there be a way to make this contact app a Wagtail component, so that we can add it when needed on the contact page? This would be a similar implementation to the AF calculator. The reason I ask is because we'd need to keep the COVID snippet above the contact form and I don't see a clear way to do that if the contact app is automatically inserting itself and wiping the rest of the content there. The other advantage to this is that we wouldn't really need to feature flag the contact app, we can add it as an option to the contact page template but not actually add the component for use yet. What do you think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good call! Lemme dig into that. I definitely don't want it to be in a modal like the calculator is but I didn't think about making it a kind of Django/Wagtail widget/component/etc
:k${'e'}y="link_index" | ||
class="contact-item contact-item--question-bubble"> | ||
<div class="contact-item__content"> | ||
<a href="{{link.href}}">{{link.label}}</a> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to pass the hotline portal url here: https://fecoig.ains.com/eCasePortal/InvestigationsCaptcha.aspx?ReturnUrl=%2fecaseportal%2f
headline: 'Unable to send your message at this time.', | ||
message: `<strong>Submitting your message has failed.</strong> You’re welcome to try again, call the FEC offices, | ||
or use the content below to send your message through another platform.<br><br> | ||
<strong>To:</strong> ${recipient}<br><br> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think public records' or electronic filing email is coming through correctly. If I chose public records, I should be getting the public records email, but instead I see the info email.
<ul | ||
v-if="submissionMessages.emailLinks" | ||
class="list--buttons"> | ||
<li v-for="(link, link_index) in submissionMessages.emailLinks" | ||
><a class="button--standard" :href="link.href" target="_blank">{{link.label}}</a></li> | ||
</ul> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
d'oh!
This will be fixed with the next commit
Summary
Overhauling the Contact page
Required reviewers
Impacted areas of the application
The contact page
Screenshots
Related PRs
None
How to test
npm i
npm run build