-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
new: bump plugin API to 3.10.0. #41
base: master
Are you sure you want to change the base?
Conversation
Support new `addOutput` extractor plugin `field_info` field. Signed-off-by: Federico Di Pierro <[email protected]>
/hold |
Signed-off-by: Federico Di Pierro <[email protected]>
e3a4fb4
to
68377c2
Compare
Will need to bump tp 3.9.0 after falcosecurity/libs#2147 is merged |
Signed-off-by: Federico Di Pierro <[email protected]>
Signed-off-by: Federico Di Pierro <[email protected]>
Will bump to 3.10.0 once falcosecurity/libs#2152 is merged :D |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: FedeDP The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
1 similar comment
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: FedeDP The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
I pushed a commit without DCO because it relies on falcosecurity/libs#2152 HEAD hash. |
@@ -21,7 +21,7 @@ OUTPUT := lib$(NAME).so | |||
|
|||
SDK_DIR := ../.. | |||
SDK_INCLUDE := $(SDK_DIR)/include/ | |||
CXX_FLAGS := -shared -std=c++0x -Wall -fPIC -I$(SDK_INCLUDE) | |||
CXX_FLAGS := -shared -std=c++17 -Wall -fPIC -I$(SDK_INCLUDE) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Switched plugin build to c++17 by default since this is what we build Falco with.
examples/syscall_async/plugin.cpp
Outdated
@@ -112,6 +112,22 @@ class my_plugin | |||
} | |||
} | |||
|
|||
// (optional) | |||
void dump(std::unique_ptr<falcosecurity::async_event_handler> h) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is how the new dump
API would look like for end users (plugin writers).
ss_plugin_rc dump(ss_plugin_owner_t* o, | ||
const ss_plugin_async_event_handler_t h) | ||
{ | ||
FALCOSECURITY_CATCH_ALL(Base::m_last_err_storage, { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just return SS_PLUGIN_FAILURE
if any exception was thrown during the dump
.
/check-dco |
cc @FedeDP |
eb80c81
to
76eac92
Compare
Add support for new `dump_state` async capability API. Signed-off-by: Federico Di Pierro <[email protected]>
76eac92
to
582d8a1
Compare
Since falcosecurity/libs#2152 was merged to libs master, i amended last commit and added DCO. |
What type of PR is this?
/kind feature
Any specific area of the project related to this PR?
/area plugin-sdk
What this PR does / why we need it:
Plugin API 3.8.0 introduced support for suggested output formats in extractor plugins; support it.
falcosecurity/libs#2116
Plugin API 3.9.0 introduced support for exposing
get_owner_last_error
in capture listening capability.falcosecurity/libs#2147
Plugin API 3.10.0 introduced support for new async capability related
dump_state
API.falcosecurity/libs#2152
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: