Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extract common toSerializedPage test function #9462

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Extract common toSerializedPage test function #9462

wants to merge 1 commit into from
+78 −43

Conversation

pramodsatya
Copy link
Collaborator

Refactors toSerializedPage function to add a common helper function for serializing
RowVector to PrestoPage format, in file SerializedPageUtil.cpp.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Apr 12, 2024
@netlify Netlify
Copy link

netlify bot commented Apr 12, 2024 •
edited
Loading

✅ Deploy Preview for meta-velox canceled.

Name Link
🔨 Latest commit f5258c5
🔍 Latest deploy log https://app.netlify.com/sites/meta-velox/deploys/6713b3c096192800085879e6

@pramodsatya
Copy link
Collaborator Author

Hi @czentgr, @aditi-pandit, could you please help review this PR?

czentgr
czentgr approved these changes Apr 19, 2024
View reviewed changes
Copy link
Collaborator

@czentgr czentgr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this!

@stale Stale
Copy link

stale bot commented Jul 18, 2024

This pull request has been automatically marked as stale because it has not had recent activity. If you'd still like this PR merged, please comment on the PR, make sure you've addressed reviewer comments, and rebase on the latest main. Thank you for your contributions!

@stale stale bot added the stale label Jul 18, 2024
@stale stale bot removed the stale label Jul 19, 2024
@pramodsatya pramodsatya marked this pull request as ready for review July 19, 2024 17:35
aditi-pandit
aditi-pandit reviewed Jul 19, 2024
View reviewed changes
Copy link
Collaborator

@aditi-pandit aditi-pandit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @pramodsatya. Just one question.

velox/exec/tests/utils/SerializedPageUtil.cpp Outdated
std::unique_ptr<SerializedPage> toSerializedPage(
const RowVectorPtr& vector,
memory::MemoryPool* pool,
std::shared_ptr<OutputBufferManager> bufferManager) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should bufferManager be const& ?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated, thanks @aditi-pandit. Could you please take another look?

aditi-pandit
aditi-pandit approved these changes Jul 19, 2024
View reviewed changes
Copy link
Collaborator

@aditi-pandit aditi-pandit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @pramodsatya

@aditi-pandit
Copy link
Collaborator

@kgpai @kagamiori : Please can you help with review and merge.

@aditi-pandit aditi-pandit changed the title Refactor toSerializedPage function Extract common toSerializedPage test function Jul 19, 2024
@stale Stale
Copy link

stale bot commented Oct 19, 2024

This pull request has been automatically marked as stale because it has not had recent activity. If you'd still like this PR merged, please comment on the PR, make sure you've addressed reviewer comments, and rebase on the latest main. Thank you for your contributions!

@stale stale bot added the stale label Oct 19, 2024
@pramodsatya
Copy link
Collaborator Author

Hi @kgpai, @kagamiori, could you please help review/merge this change?

@stale stale bot removed the stale label Oct 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@czentgr czentgr czentgr approved these changes

@aditi-pandit aditi-pandit aditi-pandit approved these changes

@kgpai kgpai Awaiting requested review from kgpai

@kagamiori kagamiori Awaiting requested review from kagamiori

@assignUser assignUser Awaiting requested review from assignUser assignUser is a code owner

@majetideepak majetideepak Awaiting requested review from majetideepak majetideepak is a code owner

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pramodsatya @aditi-pandit @czentgr @facebook-github-bot