Reclaim from join table directly from hash join bridge #11300
+522
−210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
✅ Deploy Preview for meta-velox canceled.
|
tanjialiang
force-pushed
the
bridge_reclaim
branch
from
91d5931
to
846de45
Compare
|
@tanjialiang has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
tanjialiang
force-pushed
the
bridge_reclaim
branch
from
846de45
to
1a916a6
Compare
tanjialiang
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add ability to allow hash join bridge to be able to reclaim directly the transferred table from hash build. This is useful in the condition when build has finished and table has been transferred to bridge, but probe side was blocked by downstream operators from performing any of its initial isBlocked() calls. When this happens, probe does not have the ability to spill because it has no knowledge about the ongoing join, neither does build because the table is transferred to bridge already. So when this happens, we rely on bridge to perform the table spill.