Update Base64 variable names for better readability #11299
+248
−243
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
✅ Deploy Preview for meta-velox canceled.
|
There was a problem hiding this comment.
@Joe-Abraham The header refactor seems to be missing some code comments.
Can you clarify? Thanks.
| @@ -32,125 +29,100 @@ class Base64 { | |||
| static const size_t kCharsetSize = 64; | |||
| static const size_t kReverseIndexSize = 256; | |||
|
|
|||
| /// Character set used for encoding purposes. | |||
| /// Contains specific characters that form the encoding scheme. | |||
| /// Character set used for Base64 encoding. | |||
There was a problem hiding this comment.
@Joe-Abraham why remove /// Contains specific characters that form the encoding scheme.?
| using Charset = std::array<char, kCharsetSize>; | ||
|
|
||
| /// Reverse lookup table for decoding purposes. | ||
| /// Maps each possible encoded character to its corresponding numeric value | ||
| /// within the encoding base. |
There was a problem hiding this comment.
Why remove the other comments?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up PR: #10371
The following changes are done in this PR.