Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve documentation for hive.gcs.endpoint #11289

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Improve documentation for hive.gcs.endpoint #11289

wants to merge 1 commit into from

Conversation

majetideepak
Copy link
Collaborator

@majetideepak majetideepak commented Oct 17, 2024 •
edited
Loading

This commit got left out here #11235
I removed the default endpoint value from that PR since it was not required.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 17, 2024
@netlify Netlify
Copy link

netlify bot commented Oct 17, 2024 •
edited
Loading

✅ Deploy Preview for meta-velox canceled.

Name Link
🔨 Latest commit 6f392be
🔍 Latest deploy log https://app.netlify.com/sites/meta-velox/deploys/671127bbdb81130008b9cec8

@majetideepak majetideepak changed the title Add default to hive.gcs.endpoint and update doc Improve documentation for hive.gcs.endpoint Oct 17, 2024
@majetideepak majetideepak deleted the fix-gcs-endpoint branch October 17, 2024 20:15
@majetideepak majetideepak restored the fix-gcs-endpoint branch October 17, 2024 20:16
@majetideepak majetideepak reopened this Oct 17, 2024
@majetideepak majetideepak added the ready-to-merge PR that have been reviewed and are ready for merging. PRs with this tag notify the Velox Meta oncall label Oct 17, 2024
czentgr
czentgr approved these changes Oct 17, 2024
View reviewed changes
Copy link
Collaborator

@czentgr czentgr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, this is because it wasn't reimported I suppose.

@facebook-github-bot
Copy link
Contributor

@kgpai has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@czentgr czentgr czentgr approved these changes

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. ready-to-merge PR that have been reviewed and are ready for merging. PRs with this tag notify the Velox Meta oncall
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@majetideepak @facebook-github-bot @czentgr