Fix Presto's format_datetime function with time zone #11283
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 16, 2024 15:06
Summary: Presto's to_iso8601 UDF uses JODA's default ISODateTimeFormat.dateTime() formatter which uses the string 'Z' in place of the time zone offset if the time zone is UTC. https://www.joda.org/joda-time/apidocs/org/joda/time/format/ISODateTimeFormat.html#dateTime-- Internally JODA's DateTimeFormatter does this by taking an optional hard coded string to use for the time zone offset if it's zero. I added something similar to Velox's DateTimeFormatter.format and setting it in the to_iso8601 implementation. I checked and other Presto UDFs that format TimestampWithTimeZones as strings, e.g. format_datetime, do not use this option, so they do not need to be updated. Differential Revision: D64488962
Summary: The format_datetime currently outptus the time zone id if for 3 or fewer 'z' characters in the format string. However, the JODA library, which this is based on, does this for 3 or more 'Z' characters. https://www.joda.org/joda-time/apidocs/org/joda/time/format/DateTimeFormat.html This diff fixes this, as well as adds support for a single 'Z' (which outputs the same thing as 'ZZ' just without the colon). So 'Z' is fully supported for any number of characters. Differential Revision: D64500193
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D64500193 |
✅ Deploy Preview for meta-velox canceled.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
The format_datetime currently outptus the time zone id if for 3 or fewer 'z' characters
in the format string. However, the JODA library, which this is based on, does this for
3 or more 'Z' characters.
https://www.joda.org/joda-time/apidocs/org/joda/time/format/DateTimeFormat.html
This diff fixes this, as well as adds support for a single 'Z' (which outputs the same
thing as 'ZZ' just without the colon). So 'Z' is fully supported for any number of
characters.
Differential Revision: D64500193