save HandshakeLogging into AttemptVersionFallback when we receive it

Summary: let's save the received AttemptVersionFallback after it's passed to us from ServerProtocol's event handler. We will need to pass the handshakeLogging property of AttemptVersionFallback later on into our logging callbacks.

Reviewed By: mingtaoy

Differential Revision: D66325817

fbshipit-source-id: 27b1799e3f1fb7b23e874a63c4375c6ef8b13294

fizz/server/Actions.h

@@ -11,6 +11,7 @@
 #include <boost/variant.hpp>
 
 #include <fizz/protocol/Actions.h>
+#include <fizz/server/HandshakeLogging.h>
 #include <fizz/util/Variant.h>
 #include <folly/Optional.h>
 #include <folly/futures/Future.h>
@@ -38,6 +39,11 @@ struct AttemptVersionFallback {
    * for processing the ClientHello.
    */
   folly::Optional<std::string> sni;
+
+  /**
+   * Parsed fields from the ClientHello for logging purposes.
+   */
+  std::unique_ptr<HandshakeLogging> handshakeLogging;
 };
 
 /**

fizz/server/AsyncFizzServer-inl.h

@@ -374,7 +374,9 @@ void AsyncFizzServerT<SM>::ActionMoveVisitor::operator()(
     fallback.clientHello->prependChain(server_.transportReadBuf_.move());
   }
   callback->fizzHandshakeAttemptFallback(AttemptVersionFallback{
-      std::move(fallback.clientHello), std::move(fallback.sni)});
+      std::move(fallback.clientHello),
+      std::move(fallback.sni),
+      std::move(fallback.handshakeLogging)});
 }
 
 template <typename SM>

fizz/server/ServerProtocol.cpp

@@ -1257,6 +1257,12 @@ EventHandler<ServerTypes, StateEnum::ExpectingClientHello, Event::ClientHello>::
                            .hostname->to<std::string>();
       }
 
+      auto logging = state.handshakeLogging();
+      if (logging) {
+        fallback.handshakeLogging =
+            std::make_unique<HandshakeLogging>(*logging);
+      }
+
       return actions(
           MutateState(&Transition<StateEnum::Error>), std::move(fallback));
     } else {

fizz/server/test/AsyncFizzServerTest.cpp

@@ -299,7 +299,8 @@ TEST_F(AsyncFizzServerTest, TestAttemptVersionFallback) {
                 [](State& newState) { newState.state() = StateEnum::Error; }),
             AttemptVersionFallback{
                 IOBuf::copyBuffer("ClientHello"),
-                folly::Optional<std::string>("www.hostname.com")});
+                folly::Optional<std::string>("www.hostname.com"),
+                std::make_unique<HandshakeLogging>()});
       }));
   EXPECT_CALL(handshakeCallback_, _fizzHandshakeAttemptFallback(_))
       .WillOnce(Invoke([&](AttemptVersionFallback& fallback) {