Merge pull request #157 from facebook/feature/preview-issues

Handle issue with preview #141 #146
facebookarchive · Feb 26, 2021 · f5ff5bf · f5ff5bf
2 parents cddef6f + b353ad6
commit f5ff5bf
Show file tree

Hide file tree

Showing 3 changed files with 31 additions and 24 deletions.
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -30,7 +30,7 @@
     "react-dom": "^15.6.1",
     "react-joyride": "^1.11.4",
     "react-sortable-hoc": "^0.6.8",
-    "semantic-ui-react": "^0.77.2",
+    "semantic-ui-react": "^0.80.0",
     "yargs-parser": "^18.1.3"
   },
   "devDependencies": {

diff --git a/src/js/components/Preview.react.js b/src/js/components/Preview.react.js
@@ -21,7 +21,7 @@ type Props = BaseProps & { hidden: boolean };
 type State = {
   previewLoading: boolean,
   sourceLoading: boolean,
-  activeTab: number
+  activeTab: number,
 };
 
 class Preview extends React.Component<Props, State> {
@@ -53,25 +53,31 @@ class Preview extends React.Component<Props, State> {
 
   reloadPreview = debounce(() => {
     if (this.state.activeTab == 0 && this.preview != null) {
+      const generatedRules = RuleExporter.export(
+        this.props.rules,
+        this.props.settings
+      );
+      const hasRequiredField = !!(
+        generatedRules &&
+        generatedRules.rules.find(rule => rule.class === 'GlobalRule')
+      );
       this.preview.loadURL(
         'http://127.0.0.1:8105/preview.php?url=' +
           encodeURIComponent(this.props.editor.url),
-        {
-          postData: [
-            {
-              type: 'rawData',
-              bytes: Buffer.from(
-                'rules=' +
-                  encodeURIComponent(
-                    JSON.stringify(
-                      RuleExporter.export(this.props.rules, this.props.settings)
-                    )
-                  )
-              ),
-            },
-          ],
-          extraHeaders: 'Content-Type: application/x-www-form-urlencoded',
-        }
+        hasRequiredField
+          ? {
+            postData: [
+              {
+                type: 'rawData',
+                bytes: Buffer.from(
+                  'rules=' +
+                      encodeURIComponent(JSON.stringify(generatedRules))
+                ),
+              },
+            ],
+            extraHeaders: 'Content-Type: application/x-www-form-urlencoded',
+          }
+          : null
       );
     }
   }, 1000);