Add rust_cxx_bridge CMake function #222
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request was exported from Phabricator. Differential Revision: D51160627 |
jdelliot
pushed a commit
to jdelliot/katran
that referenced
this pull request
Nov 10, 2023
Summary: X-link: facebookexperimental/edencommon#14 X-link: facebook/wangle#222 X-link: facebook/proxygen#473 X-link: facebook/hhvm#9411 X-link: facebook/fbthrift#587 X-link: facebookincubator/velox#7518 We need a better way to create cxxbridges - something that uses the recommended method of cxxbridge-cmd. This function creates C++ bindings using the [cxx] crate. Original function found here: https://github.com/corrosion-rs/corrosion/blob/master/cmake/Corrosion.cmake#L1390 Differential Revision: D51160627
jdelliot
force-pushed
the
export-D51160627
branch
from
f4ebdac to
4cd5bde
Compare
|
This pull request was exported from Phabricator. Differential Revision: D51160627 |
jdelliot
force-pushed
the
export-D51160627
branch
from
4cd5bde to
76150d4
Compare
|
This pull request was exported from Phabricator. Differential Revision: D51160627 |
jdelliot
force-pushed
the
export-D51160627
branch
from
76150d4 to
c86230a
Compare
|
This pull request was exported from Phabricator. Differential Revision: D51160627 |
jdelliot
force-pushed
the
export-D51160627
branch
from
c86230a to
8c70d11
Compare
|
This pull request was exported from Phabricator. Differential Revision: D51160627 |
jdelliot
force-pushed
the
export-D51160627
branch
from
8c70d11 to
8af74f2
Compare
|
This pull request was exported from Phabricator. Differential Revision: D51160627 |
jdelliot
force-pushed
the
export-D51160627
branch
from
8af74f2 to
1350392
Compare
|
This pull request was exported from Phabricator. Differential Revision: D51160627 |
Summary: X-link: facebookincubator/hsthrift#120 X-link: facebook/folly#2096 X-link: facebookexperimental/edencommon#14 X-link: facebook/mvfst#322 X-link: facebookincubator/delos_core#9 X-link: facebook/fboss#166 X-link: facebookincubator/zstrong#617 X-link: facebookincubator/katran#208 X-link: facebookincubator/fizz#102 X-link: facebookexternal/traffixr#4 X-link: facebook/watchman#1173 X-link: facebook/proxygen#473 X-link: facebook/hhvm#9411 X-link: facebook/fbthrift#587 X-link: facebookincubator/velox#7518 We need a better way to create cxxbridges - something that uses the recommended method of cxxbridge-cmd. This function creates C++ bindings using the [cxx] crate. Original function found here: https://github.com/corrosion-rs/corrosion/blob/master/cmake/Corrosion.cmake#L1390 Reviewed By: xavierd Differential Revision: D51160627
jdelliot
force-pushed
the
export-D51160627
branch
from
1350392 to
98dc9a1
Compare
|
This pull request was exported from Phabricator. Differential Revision: D51160627 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
X-link: facebook/proxygen#473
X-link: facebook/hhvm#9411
X-link: facebook/fbthrift#587
X-link: facebookincubator/velox#7518
We need a better way to create cxxbridges - something that uses the recommended method of cxxbridge-cmd.
This function creates C++ bindings using the [cxx] crate.
Original function found here: https://github.com/corrosion-rs/corrosion/blob/master/cmake/Corrosion.cmake#L1390
Differential Revision: D51160627